From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org,
Erik de Castro Lopo <mle+tools@mega-nerd.com>,
Peter Jovanovic <petar.jovanovic@imgtec.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Riku Voipio <riku.voipio@iki.fi>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] linux-user: create target_structs header to place ipc_perm and shmid_ds
Date: Tue, 29 Oct 2013 21:51:06 +0100 [thread overview]
Message-ID: <52701FBA.4040200@suse.de> (raw)
In-Reply-To: <20131025202521.08eca69156778b1d37017a21@mega-nerd.com>
Hi,
Am 25.10.2013 11:25, schrieb Erik de Castro Lopo:
> Petar Jovanovic wrote:
>
>> From: Petar Jovanovic <petar.jovanovic@imgtec.com>
>>
>> Creating target_structs header in linux-user/$arch/ and making
>> target_ipc_perm and target_shmid_ds its first inhabitants.
>> The struct defintions may/should be further fine-tuned by arch maintainers.
>>
>> Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>
>
> Reviewed-by: Erik de Castro Lopo <erikd@mega-nerd.com>
>
>
> I'm relatively new to QEMU and this is my first review. This change
> looks sane to me, applies cleanly and compiles without any new warnings.
What's missing is file headers for the new .h files indicating which
license they are under. The general concept of moving stuff from big .c
to several .h files seems welcome to me.
> In future I will be attempting to review anything in the linux-user
> tree.
Review is always appreciated. :)
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2013-10-29 20:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 17:32 [Qemu-devel] [PATCH] linux-user: create target_structs header to place ipc_perm and shmid_ds Petar Jovanovic
2013-10-15 12:44 ` Petar Jovanovic
2013-10-22 15:13 ` Petar Jovanovic
2013-10-29 16:10 ` Petar Jovanovic
2013-10-25 9:25 ` Erik de Castro Lopo
2013-10-29 18:59 ` Erik de Castro Lopo
2013-10-29 20:51 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52701FBA.4040200@suse.de \
--to=afaerber@suse.de \
--cc=aurelien@aurel32.net \
--cc=mle+tools@mega-nerd.com \
--cc=petar.jovanovic@imgtec.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).