From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57263)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VbGFu-000224-1S
	for qemu-devel@nongnu.org; Tue, 29 Oct 2013 16:51:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VbGFs-0006sC-PZ
	for qemu-devel@nongnu.org; Tue, 29 Oct 2013 16:51:13 -0400
Received: from cantor2.suse.de ([195.135.220.15]:50254 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VbGFs-0006s5-JO
	for qemu-devel@nongnu.org; Tue, 29 Oct 2013 16:51:12 -0400
Message-ID: <52701FBA.4040200@suse.de>
Date: Tue, 29 Oct 2013 21:51:06 +0100
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1381253533-111250-1-git-send-email-petar.jovanovic@rt-rk.com>
	<20131025202521.08eca69156778b1d37017a21@mega-nerd.com>
In-Reply-To: <20131025202521.08eca69156778b1d37017a21@mega-nerd.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] linux-user: create target_structs header
 to place ipc_perm and shmid_ds
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, Erik de Castro Lopo <mle+tools@mega-nerd.com>, Peter Jovanovic <petar.jovanovic@imgtec.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Riku Voipio <riku.voipio@iki.fi>, Aurelien Jarno <aurelien@aurel32.net>

Hi,

Am 25.10.2013 11:25, schrieb Erik de Castro Lopo:
> Petar Jovanovic wrote:
>=20
>> From: Petar Jovanovic <petar.jovanovic@imgtec.com>
>>
>> Creating target_structs header in linux-user/$arch/ and making
>> target_ipc_perm and target_shmid_ds its first inhabitants.
>> The struct defintions may/should be further fine-tuned by arch maintai=
ners.
>>
>> Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>
>=20
> Reviewed-by: Erik de Castro Lopo <erikd@mega-nerd.com>
>=20
>=20
> I'm relatively new to QEMU and this is my first review. This change
> looks sane to me, applies cleanly and compiles without any new warnings=
.

What's missing is file headers for the new .h files indicating which
license they are under. The general concept of moving stuff from big .c
to several .h files seems welcome to me.

> In future I will be attempting to review anything in the linux-user
> tree.

Review is always appreciated. :)

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg