From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50200)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1VbQBr-0004ru-Sj
	for qemu-devel@nongnu.org; Wed, 30 Oct 2013 03:27:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1VbQBi-0000OD-W1
	for qemu-devel@nongnu.org; Wed, 30 Oct 2013 03:27:43 -0400
Received: from e28smtp07.in.ibm.com ([122.248.162.7]:57843)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1VbQBi-0000O1-8o
	for qemu-devel@nongnu.org; Wed, 30 Oct 2013 03:27:34 -0400
Received: from /spool/local
	by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <xiawenc@linux.vnet.ibm.com>;
	Wed, 30 Oct 2013 12:57:27 +0530
Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62])
	by d28dlp02.in.ibm.com (Postfix) with ESMTP id 99BCD3940057
	for <qemu-devel@nongnu.org>; Wed, 30 Oct 2013 12:57:03 +0530 (IST)
Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64])
	by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	r9U7RMqE42598648
	for <qemu-devel@nongnu.org>; Wed, 30 Oct 2013 12:57:22 +0530
Received: from d28av02.in.ibm.com (localhost [127.0.0.1])
	by d28av02.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id
	r9U7RPvs022316
	for <qemu-devel@nongnu.org>; Wed, 30 Oct 2013 12:57:25 +0530
Message-ID: <5270B4DC.9040608@linux.vnet.ibm.com>
Date: Wed, 30 Oct 2013 15:27:24 +0800
From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1382321765-29052-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1382321765-29052-4-git-send-email-xiawenc@linux.vnet.ibm.com>
	<5265917D.3000903@redhat.com>
	<20131029181845.GA25726@dhcp-200-207.str.redhat.com>
In-Reply-To: <20131029181845.GA25726@dhcp-200-207.str.redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 3/6] qapi: rename prefix QEVENT to Q_EVENT
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>, Eric Blake <eblake@redhat.com>
Cc: pbonzini@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com

于 2013/10/30 2:18, Kevin Wolf 写道:
> Am 21.10.2013 um 22:41 hat Eric Blake geschrieben:
>> On 10/21/2013 03:16 AM, Wenchao Xia wrote:
>>> The define will be moved to qapi-schema.json later, so rename the
>>> prefix to match its naming style.
>> Wouldn't it be simpler to fix the code generator to special case QEvent
>> to turn into QEVENT, instead of having to go through this churn?  But if
>> we _like_ the Q_EVENT_ prefix, then this looks fairly mechanical:
> Or rather, instead of special casing QEvent, it shouldn't insert
> underscores if there is nothing between the two capital letters.
>
> I've had a similar case with AIO in the blockdev-add series; and while
> renaming it to Aio worked, this kind of thing doesn't seem to be a rare
> exception in practice, so it might be worth adjusting the generator.
>
> Kevin
It seems the right way, will adjust the generator.