From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47901)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VbUfn-0007Nd-MO
	for qemu-devel@nongnu.org; Wed, 30 Oct 2013 08:15:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VbUff-000074-9L
	for qemu-devel@nongnu.org; Wed, 30 Oct 2013 08:14:55 -0400
Received: from mail-qc0-x230.google.com ([2607:f8b0:400d:c01::230]:36118)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VbUff-00006p-5f
	for qemu-devel@nongnu.org; Wed, 30 Oct 2013 08:14:47 -0400
Received: by mail-qc0-f176.google.com with SMTP id s19so717901qcw.35
	for <qemu-devel@nongnu.org>; Wed, 30 Oct 2013 05:14:46 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5270F830.2000409@redhat.com>
Date: Wed, 30 Oct 2013 13:14:40 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1382978620-16641-1-git-send-email-pbonzini@redhat.com>
	<1382978620-16641-16-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1382978620-16641-16-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 15/24] ide: prepare to move restart to
	common code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com

Il 28/10/2013 17:43, Paolo Bonzini ha scritto:
> Using ide_start_dma instead of bmdma_start_dma introduces a new
> assignment "s->bus->dma->unit = s->unit".  This introduces no
> change because ide_handle_rw_error has already done the same
> assignment.

This remark is stale.

Paolo