From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58394) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbV8I-0007fQ-Nb for qemu-devel@nongnu.org; Wed, 30 Oct 2013 08:44:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbV8C-0003YX-PP for qemu-devel@nongnu.org; Wed, 30 Oct 2013 08:44:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28749) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbV8C-0003YG-HY for qemu-devel@nongnu.org; Wed, 30 Oct 2013 08:44:16 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9UCiF43018316 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 30 Oct 2013 08:44:15 -0400 Message-ID: <5270FF1B.8080609@redhat.com> Date: Wed, 30 Oct 2013 13:44:11 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1382978620-16641-1-git-send-email-pbonzini@redhat.com> <1382978620-16641-10-git-send-email-pbonzini@redhat.com> <20131030122931.GK2807@dhcp-200-207.str.redhat.com> In-Reply-To: <20131030122931.GK2807@dhcp-200-207.str.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/24] ide: wrap start_dma callback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, mst@redhat.com Il 30/10/2013 13:29, Kevin Wolf ha scritto: >> > bdrv_acct_start(s->bs, &s->acct, size, BDRV_ACCT_READ); >> > s->status = READY_STAT | SEEK_STAT | DRQ_STAT; >> > - s->bus->dma->ops->start_dma(s->bus->dma, s, >> > - ide_atapi_cmd_read_dma_cb); >> > + ide_start_dma(s, ide_atapi_cmd_read_dma_cb); > I was wondering whether the s->status update should be moved into > ide_start_dma(). Then I noticed that the value is different here, > because it's lacking BSY. Probably an inconsistency that wouldn't hurt > to get rid of? (The spec says that during a DMA operation BSY or DRQ or > both must be set.) You are probably right. BTW, the last patch in the series does that for another assignment that is common to all ide_start_dma call sites. Paolo