From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38126) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbVdP-0006Ed-10 for qemu-devel@nongnu.org; Wed, 30 Oct 2013 09:16:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbVdH-0006hz-8b for qemu-devel@nongnu.org; Wed, 30 Oct 2013 09:16:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39414) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbVdH-0006hk-0A for qemu-devel@nongnu.org; Wed, 30 Oct 2013 09:16:23 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9UDGL0K018944 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 30 Oct 2013 09:16:21 -0400 Message-ID: <527106A1.3090904@redhat.com> Date: Wed, 30 Oct 2013 14:16:17 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1382978620-16641-1-git-send-email-pbonzini@redhat.com> <1382978620-16641-11-git-send-email-pbonzini@redhat.com> <20131030124746.GL2807@dhcp-200-207.str.redhat.com> In-Reply-To: <20131030124746.GL2807@dhcp-200-207.str.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/24] ide: add trigger_irq callback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, mst@redhat.com Il 30/10/2013 13:47, Kevin Wolf ha scritto: > This whole add_status(BM_STATUS_INT) is weird and doesn't seem to make > sense. For AHCI it triggers the actual IRQ, whereas for BMIDE it only > sets the status register bit and requires a separate call to trigger the > IRQ. This function is ide_set_irq(), which in turn ends up completely > ignored by AHCI (ahci_irq_set() is an empty function). The problem is that the IRQ ack is done differently in AHCI (using the write-1-clears register PORT_IRQ_STAT; PORT_IRQ_MASK can also modify the status of the interrupt line) and PATA (reading 0x1f7). So perhaps the legacy PIO code of hw/ide/core.c should be abstracted out, including the new restart support. (BTW, to test this with AHCI I rigged up a modified version of AHCI that has the legacy ports, so that I could run the new qtest on it). Michael, can you look at this? Paolo