From: "Andreas Färber" <afaerber@suse.de>
To: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel <qemu-devel@nongnu.org>
Cc: Markus Armbruster <armbru@redhat.com>,
Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] How to add qemu-system-$(target) as a dependency for qtests
Date: Wed, 30 Oct 2013 17:12:43 +0100 [thread overview]
Message-ID: <52712FFB.3020302@suse.de> (raw)
In-Reply-To: <CAJSP0QW2-c8EbEb1PsnwQrcw0ornKAnFwNSy6Qy+Bn_pS11L6Q@mail.gmail.com>
Am 30.10.2013 16:07, schrieb Stefan Hajnoczi:
> I came across this little tests/Makefile annoyance:
> If you modify QEMU code and then run "make check" it will not rebuild QEMU.
>
> This can be confusing during development when you expect changing the
> code and rerunning the tests to pass :).
>
> I played with tests/Makefile but was unable to add the right
> dependency. We need something that makes all libqtest tests depend on
> $(TARGET)-softmmu/qemu-system-$(TARGET) at "make check" time.
>
> This way QEMU gets rebuilt if "make check" will execute the QEMU binary.
>
> Any ideas?
Technically, tests/Makefile is part of ./Makefile, whereas
qemu-system-$(TARGET) gets built recursively in Makefile.target.
Thus, something like this might work:
check-qtest-x86_64: subdir-x86_64-softmmu
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2013-10-30 16:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 15:07 [Qemu-devel] How to add qemu-system-$(target) as a dependency for qtests Stefan Hajnoczi
2013-10-30 16:09 ` Paolo Bonzini
2013-10-31 12:30 ` Stefan Hajnoczi
2013-10-30 16:12 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52712FFB.3020302@suse.de \
--to=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).