From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60566)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sebastian@macke.de>) id 1Vbd09-0006mg-LF
	for qemu-devel@nongnu.org; Wed, 30 Oct 2013 17:08:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sebastian@macke.de>) id 1Vbd03-0002Dc-QO
	for qemu-devel@nongnu.org; Wed, 30 Oct 2013 17:08:29 -0400
Received: from www11.your-server.de ([213.133.104.11]:55530)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sebastian@macke.de>) id 1Vbd03-0002DN-Jw
	for qemu-devel@nongnu.org; Wed, 30 Oct 2013 17:08:23 -0400
Message-ID: <52717543.7090804@macke.de>
Date: Wed, 30 Oct 2013 14:08:19 -0700
From: Sebastian Macke <sebastian@macke.de>
MIME-Version: 1.0
References: <1383073495-5332-1-git-send-email-sebastian@macke.de>
	<1383073495-5332-12-git-send-email-sebastian@macke.de>
	<527150E2.5070200@twiddle.net> <527158F2.9000000@macke.de>
	<5271624F.8050104@twiddle.net>
In-Reply-To: <5271624F.8050104@twiddle.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 11/13] target-openrisc: use jmp_pc as flag
 variable for branches
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: openrisc@openrisc.net, qemu-devel@nongnu.org, proljc@gmail.com

On 30/10/2013 12:47 PM, Richard Henderson wrote:
> On 10/30/2013 12:07 PM, Sebastian Macke wrote:
>>>>        case JUMP_BRANCH:
>>>>            {
>>>>                int l1 = gen_new_label();
>>>> -            tcg_gen_brcondi_tl(TCG_COND_NE, dc->btaken, 0, l1);
>>>> +            tcg_gen_brcondi_tl(TCG_COND_NE, jmp_pc, 0, l1);
>>>>                gen_goto_tb(dc, 1, dc->pc);
>>>>                gen_set_label(l1);
>>>> -            tcg_temp_free(dc->btaken);
>>>>                gen_goto_tb(dc, 0, dc->j_target);
>>>>                break;
>>> ... here.
>> But j_target is not known when the delayed slot is translated separately. (E.g.
>> if the delayed slot is at a page boundary.)
> Hmm.  This was just guesswork on my part since I don't have a tree
> with your previous patch set applied; j_target of course doesn't
> exist in master.
>
> Do you have a publicly accessible tree with all your patches applied?
> I'd like to re-read the logic in the proper context.
After you are the second who demanded it:
https://github.com/s-macke/qemu/tree/or32-optimize

>
> r~