From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbtIu-0000FF-7t for qemu-devel@nongnu.org; Thu, 31 Oct 2013 10:33:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbtIp-0005k9-Bi for qemu-devel@nongnu.org; Thu, 31 Oct 2013 10:32:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14631) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbtIp-0005ju-2H for qemu-devel@nongnu.org; Thu, 31 Oct 2013 10:32:51 -0400 Message-ID: <52726A0B.4080805@redhat.com> Date: Thu, 31 Oct 2013 08:32:43 -0600 From: Eric Blake MIME-Version: 1.0 References: <1377187852-11192-1-git-send-email-pbonzini@redhat.com> <20131024023903.GD16757@G08FNSTD100614.fnst.cn.fujitsu.com> <20131031143004.GA9948@redhat.com> In-Reply-To: <20131031143004.GA9948@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GjuTVSFnvnKf2KRfOa9rbuiWIk6Trjk5G" Subject: Re: [Qemu-devel] pvpanic plans? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Hu Tao Cc: pkrempa@redhat.com, marcel.a@redhat.com, libvir-list@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, rhod@redhat.com, kraxel@redhat.com, anthony@codemonkey.ws, Paolo Bonzini , lcapitulino@redhat.com, lersek@redhat.com, afaerber@suse.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GjuTVSFnvnKf2KRfOa9rbuiWIk6Trjk5G Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/31/2013 08:30 AM, Michael S. Tsirkin wrote: > On Thu, Oct 24, 2013 at 10:39:03AM +0800, Hu Tao wrote: >> Hi All, >> >> I know it's been a long time since this thread. But qemu 1.7 is >> releasing, do you have any consensus on this? >> >> Thanks. >=20 >=20 > I think the biggest issue is the new PANICKED state. > Guests already have simple ways to halt the CPU, > and actually do. I think a new state was a mistake. > So how about the following? Does it break anything? > (Untested). >=20 > Signed-off-by: Michael S. Tsirkin >=20 > diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c > index 226e298..2055afc 100644 > --- a/hw/misc/pvpanic.c > +++ b/hw/misc/pvpanic.c > @@ -51,7 +51,6 @@ static void handle_event(int event) > =20 > if (event & PVPANIC_PANICKED) { > panicked_mon_event("pause"); > - vm_stop(RUN_STATE_GUEST_PANICKED); Don't you still need to halt the guest on a panic event, for management to have a chance to choose what to do about the panic? I'm suspecting this patch does break things. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --GjuTVSFnvnKf2KRfOa9rbuiWIk6Trjk5G Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJScmoLAAoJEKeha0olJ0Nq4D4IAKgmGzxD0SSb/Kk7+P2gLLTj 6ukcb/yI8XpS6QPY54LKqe48N8txinRN2dDrFlqIeMVjdcrUcfxjvN1MwJ8MKEAs Ua2RaUOT2tm+xjkAJDJC9TQvnwKDRT3coUOPQtIKeow5IpI62YGJ1FL0CgsnbEZH I+Z+HAKib2Mt+WAVcUDcGcEqPY/jNpBqEgHi9NLlO9A+yazA4kKEZrp4uZ+Yi7C5 jrQt3IJfNNKzjSziRi2pS5PAB85pcD4mz0jLAJclQwzrW/4AV/AVz22J3n1dKiTU DpRCCfSYT1OcYp/11oK2+gKCdU1bCjqQh6HhUkwVIlCwOedcPzgzo+iLTlFJdiw= =f7F0 -----END PGP SIGNATURE----- --GjuTVSFnvnKf2KRfOa9rbuiWIk6Trjk5G--