From: Eric Blake <eblake@redhat.com>
To: Jeff Cody <jcody@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 4/7] block: qemu-iotests, add quotes to $TEST_IMG usage in 019
Date: Thu, 31 Oct 2013 11:00:49 -0600 [thread overview]
Message-ID: <52728CC1.8000104@redhat.com> (raw)
In-Reply-To: <f63a770d20a201cdbaa6c38d827a8eb74048f2eb.1383231037.git.jcody@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1960 bytes --]
On 10/31/2013 09:57 AM, Jeff Cody wrote:
> There were still instances of $TEST_IMG not being properly quoted.
> This was in the usage of a string built up for a 'for' loop; modify
> the loop so we can quote $TEST_IMG properly.
>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
> tests/qemu-iotests/019 | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/qemu-iotests/019 b/tests/qemu-iotests/019
> index cd3582c..5bb18d0 100755
> --- a/tests/qemu-iotests/019
> +++ b/tests/qemu-iotests/019
> @@ -90,12 +90,12 @@ mv "$TEST_IMG" "$TEST_IMG.orig"
> # Test the conversion twice: One test with the old-style -B option and another
> # one with -o backing_file
>
> -for backing_option in "-B $TEST_IMG.base" "-o backing_file=$TEST_IMG.base"; do
> +for backing_option in "-B " "-o backing_file="; do
>
> echo
> - echo Testing conversion with $backing_option | _filter_testdir | _filter_imgfmt
> + echo Testing conversion with $backing_option$TEST_IMG.base | _filter_testdir | _filter_imgfmt
If $TEST_IMG has 2 consecutive spaces [*], this echo produces spurious
output (flattening to only 1 space). To be completely robust, you must
quote here in the same manner...
> echo
> - $QEMU_IMG convert -O $IMGFMT $backing_option "$TEST_IMG.orig" "$TEST_IMG"
> + $QEMU_IMG convert -O $IMGFMT $backing_option"$TEST_IMG.base" "$TEST_IMG.orig" "$TEST_IMG"
...as what you execute. But as that corner case of misquoting doesn't
fail the test, your patch is a strict improvement, so I'm okay whether
you post a v2, or whether you keep this as-is and add:
Reviewed-by: Eric Blake <eblake@redhat.com>
[*] My favorite test for quoting bugs is renaming a directory to use
'two spaces', because some quoting bugs are missed when you only test
'one space'.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-10-31 17:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 15:57 [Qemu-devel] [PATCH 0/7] block: qemu-iotests, more quoting fixes Jeff Cody
2013-10-31 15:57 ` [Qemu-devel] [PATCH 1/7] block: qemu-iotests, add quotes to $TEST_IMG usage io pattern tests Jeff Cody
2013-10-31 16:23 ` Eric Blake
2013-10-31 15:57 ` [Qemu-devel] [PATCH 2/7] block: qemu-iotests, fix _make_test_img() to work with spaced pathnames Jeff Cody
2013-10-31 16:23 ` Eric Blake
2013-10-31 15:57 ` [Qemu-devel] [PATCH 3/7] block: qemu-iotests, add quotes to $TEST_IMG.base usage in 017 Jeff Cody
2013-10-31 16:25 ` Eric Blake
2013-10-31 15:57 ` [Qemu-devel] [PATCH 4/7] block: qemu-iotests, add quotes to $TEST_IMG usage in 019 Jeff Cody
2013-10-31 17:00 ` Eric Blake [this message]
2013-10-31 15:57 ` [Qemu-devel] [PATCH 5/7] block: qemu-iotests, removes duplicate double quotes in 039 Jeff Cody
2013-10-31 16:27 ` Eric Blake
2013-10-31 15:57 ` [Qemu-devel] [PATCH 6/7] block: qemu-iotests, add quotes to $TEST_IMG usage for 051 Jeff Cody
2013-10-31 17:03 ` Eric Blake
2013-10-31 15:57 ` [Qemu-devel] [PATCH 7/7] block: qemu-iotests, add quotes to $TEST_IMG usage in 061 Jeff Cody
2013-10-31 16:29 ` Eric Blake
2013-11-05 14:48 ` [Qemu-devel] [PATCH 0/7] block: qemu-iotests, more quoting fixes Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52728CC1.8000104@redhat.com \
--to=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).