From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vc3fD-0001es-MT for qemu-devel@nongnu.org; Thu, 31 Oct 2013 21:36:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vc3f4-0004nT-IX for qemu-devel@nongnu.org; Thu, 31 Oct 2013 21:36:39 -0400 Received: from e28smtp03.in.ibm.com ([122.248.162.3]:47225) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vc3f3-0004mq-TY for qemu-devel@nongnu.org; Thu, 31 Oct 2013 21:36:30 -0400 Received: from /spool/local by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 1 Nov 2013 07:06:26 +0530 Received: from d28relay04.in.ibm.com (d28relay04.in.ibm.com [9.184.220.61]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id 579261258051 for ; Fri, 1 Nov 2013 07:07:05 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id rA11aMrS41943164 for ; Fri, 1 Nov 2013 07:06:22 +0530 Received: from d28av02.in.ibm.com (localhost [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id rA11aOPC028573 for ; Fri, 1 Nov 2013 07:06:24 +0530 Message-ID: <52730599.9080006@linux.vnet.ibm.com> Date: Fri, 01 Nov 2013 09:36:25 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1381458811-9854-1-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1381458811-9854-1-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V4 0/5] export internal snapshot by qemu-nbd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@gmail.com ÓÚ 2013/10/11 10:33, Wenchao Xia дµÀ: > This series allow user to read internal snapshot's contents without qemu-img > convert. > > V2: > Address Stefan's comments: > 02: add 'fall through' comments in the case statement. > 03: add doc about the difference of internal snapshot and backing chain > snapshot, which is used in previous '--snapshot' parameter. > Other: > 01,04: rebased on upstream with conflict resolved. > > v3: > Address Paolo's comments: > 02: add parameter "-l snapshot_id_or_name", rename options > snapshot-load to load-snapshot, use QemuOpts. > 03: rename snapshot-load to load-snapshot. > 04: related change to test both -l and -L case. > 05-07: add similar parameter for qemu-img convert. > Other: > 01: foldered original snapshot logic into function > bdrv_snapshot_load_tmp_by_id_or_name(), since multiple > caller present in this version. Refined error message from > ", reason: %s" to ": %s". > 02: Refined error message from ", reason: %s" to ": %s". > 03: Rename PARAM to SNAPSHOT_PARAM. > > v4: > Address Eric's comments: > 01: typo fix. > 02: squashed patch. Use only one option -l and distiguish > the cases by the starting string. > 03: remove 'eval', remove '_supported_os Linux', remove the > comments that have typo. > 04: squashed patch. Add only one option -l and distiguish > the cases by the starting string. > 05: remove indentation. > Address Paolo's comments: > 02: Use only one option -l and distiguish the cases by > the starting string. > 04: Use only one option -l and distiguish the cases by > the starting string, mark old -s as deprecated, added doc > for them. > > Wenchao Xia (5): > 1 snapshot: distinguish id and name in load_tmp > 2 qemu-nbd: support internal snapshot export > 3 qemu-iotests: add 058 internal snapshot export with qemu-nbd case > 4 qemu-img: add -l for snapshot in convert > 5 qemu-iotests: add test for snapshot in qemu-img convert > > block/qcow2-snapshot.c | 16 +++++- > block/qcow2.h | 5 ++- > block/snapshot.c | 78 +++++++++++++++++++++++++++- > include/block/block_int.h | 4 +- > include/block/snapshot.h | 15 +++++- > qemu-img-cmds.hx | 2 +- > qemu-img.c | 45 ++++++++++++++--- > qemu-img.texi | 12 +++-- > qemu-nbd.c | 47 +++++++++++++++++- > qemu-nbd.texi | 8 +++- > tests/qemu-iotests/058 | 119 ++++++++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/058.out | 44 ++++++++++++++++ > tests/qemu-iotests/check | 1 + > tests/qemu-iotests/group | 1 + > 14 files changed, 374 insertions(+), 23 deletions(-) > create mode 100755 tests/qemu-iotests/058 > create mode 100644 tests/qemu-iotests/058.out > ping?