From: Max Reitz <mreitz@redhat.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@gmail.com
Subject: Re: [Qemu-devel] [PATCH V4 5/6] blkdebug: add debug events for snapshot
Date: Sat, 02 Nov 2013 14:20:53 +0100 [thread overview]
Message-ID: <5274FC35.2090503@redhat.com> (raw)
In-Reply-To: <1381787553-12497-6-git-send-email-xiawenc@linux.vnet.ibm.com>
On 14.10.2013 23:52, Wenchao Xia wrote:
> Some code in qcow2-snapshot.c directly access bs->file, so in those
s/access/accesses/
> points error can't be injected by other events. Since the code in
Perhaps "places" instead of "points"? (And s/error/errors/)
> qcow2-snapshot.c is qcow2's internal detail similar as L1 table,
Maybe something like "qcow2-snapshot.c is similar to the other qcow2
internal code (in regards to e.g. the L1 table)" would be easier to
parse, although I'm not sure whether it has the same meaning you wanted
to convey.
> so add some debug events.
Maybe remove the "so", because you already had a "since" in the previous
subordinate clause?
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
Aside from that: Reviewed-by: Max Reitz <mreitz@redhat.com>
next prev parent reply other threads:[~2013-11-02 13:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 21:52 [Qemu-devel] [PATCH V4 0/6] qcow2: rollback the modification on fail in snapshot creation Wenchao Xia
2013-10-14 21:52 ` [Qemu-devel] [PATCH V4 1/6] snapshot: add parameter *errp in snapshot create Wenchao Xia
2013-11-02 12:39 ` Max Reitz
2013-11-04 1:47 ` Wenchao Xia
2013-11-04 21:32 ` Max Reitz
2013-10-14 21:52 ` [Qemu-devel] [PATCH V4 2/6] qcow2: add error message in qcow2_write_snapshots() Wenchao Xia
2013-11-02 12:52 ` Max Reitz
2013-11-04 1:48 ` Wenchao Xia
2013-11-04 19:46 ` Eric Blake
2013-11-05 2:19 ` Wenchao Xia
2013-10-14 21:52 ` [Qemu-devel] [PATCH V4 3/6] qcow2: do not free clusters when fail in header update in qcow2_write_snapshots Wenchao Xia
2013-11-02 13:04 ` Max Reitz
2013-11-02 13:56 ` Max Reitz
2013-11-04 1:51 ` Wenchao Xia
2013-10-14 21:52 ` [Qemu-devel] [PATCH V4 4/6] qcow2: cancel the modification on fail in qcow2_snapshot_create() Wenchao Xia
2013-11-02 13:11 ` Max Reitz
2013-10-14 21:52 ` [Qemu-devel] [PATCH V4 5/6] blkdebug: add debug events for snapshot Wenchao Xia
2013-11-02 13:20 ` Max Reitz [this message]
2013-10-14 21:52 ` [Qemu-devel] [PATCH V4 6/6] qemu-iotests: add test for qcow2 snapshot Wenchao Xia
2013-11-02 13:34 ` Max Reitz
2013-11-01 1:35 ` [Qemu-devel] [PATCH V4 0/6] qcow2: rollback the modification on fail in snapshot creation Wenchao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5274FC35.2090503@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).