From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdGQi-0000WZ-6F for qemu-devel@nongnu.org; Mon, 04 Nov 2013 04:26:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdGQZ-0005y3-8p for qemu-devel@nongnu.org; Mon, 04 Nov 2013 04:26:40 -0500 Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:56662) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdGQZ-0005xp-0N for qemu-devel@nongnu.org; Mon, 04 Nov 2013 04:26:31 -0500 Received: from /spool/local by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 4 Nov 2013 09:26:28 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 44DC1219005E for ; Mon, 4 Nov 2013 09:26:25 +0000 (GMT) Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com [9.149.37.252]) by b06cxnps4076.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id rA49Otna59965474 for ; Mon, 4 Nov 2013 09:24:57 GMT Received: from d06av11.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id rA49P7N1012298 for ; Mon, 4 Nov 2013 02:25:07 -0700 Message-ID: <527767F2.6060803@de.ibm.com> Date: Mon, 04 Nov 2013 10:25:06 +0100 From: Christian Borntraeger MIME-Version: 1.0 References: <1377187852-11192-1-git-send-email-pbonzini@redhat.com> <20131024023903.GD16757@G08FNSTD100614.fnst.cn.fujitsu.com> <20131031143004.GA9948@redhat.com> In-Reply-To: <20131031143004.GA9948@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] pvpanic plans? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Hu Tao Cc: pkrempa@redhat.com, marcel.a@redhat.com, libvir-list@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, rhod@redhat.com, kraxel@redhat.com, anthony@codemonkey.ws, Paolo Bonzini , lcapitulino@redhat.com, lersek@redhat.com, afaerber@suse.de On 31/10/13 15:30, Michael S. Tsirkin wrote: > On Thu, Oct 24, 2013 at 10:39:03AM +0800, Hu Tao wrote: >> Hi All, >> >> I know it's been a long time since this thread. But qemu 1.7 is >> releasing, do you have any consensus on this? >> >> Thanks. > > > I think the biggest issue is the new PANICKED state. I thought the problem was that the new device broke windows and all the following hazzle. > Guests already have simple ways to halt the CPU, > and actually do. I think a new state was a mistake. > So how about the following? Does it break anything? > (Untested). Please note that on s390 we also do the panic state (on a disabled wait) "target-s390x/kvm.c" ... monitor_protocol_event(QEVENT_GUEST_PANICKED, data); qobject_decref(data); vm_stop(RUN_STATE_GUEST_PANICKED); ... Currently it is possible to restart libvirt, e.g. after an update and then it will be able to fetch the full state of a guest via QMP. It will then also be able to detect that this guest panicked some time ago. I think one issue when removing the PANICKED state is that libvirt can then no longer detect that state, correct? Christian > > Signed-off-by: Michael S. Tsirkin > > diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c > index 226e298..2055afc 100644 > --- a/hw/misc/pvpanic.c > +++ b/hw/misc/pvpanic.c > @@ -51,7 +51,6 @@ static void handle_event(int event) > > if (event & PVPANIC_PANICKED) { > panicked_mon_event("pause"); > - vm_stop(RUN_STATE_GUEST_PANICKED); > return; > } > } > >