From: Peter Lieven <pl@kamp.de>
To: quintela@redhat.com
Cc: pbonzini@redhat.com, haoyu.zhang@huawei.com,
qemu-devel@nongnu.org, afaerber@suse.de,
xiaoguangrong@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [RESEND][PATCH] migration: drop MADVISE_DONT_NEED for incoming zero pages
Date: Mon, 04 Nov 2013 10:29:25 +0100 [thread overview]
Message-ID: <527768F5.5080909@kamp.de> (raw)
In-Reply-To: <87d2mvouc5.fsf@elfo.elfo>
On 24.10.2013 12:07, Juan Quintela wrote:
> Peter Lieven <pl@kamp.de> wrote:
>> The madvise for zeroed out pages was introduced when every transferred
>> zero page was memset to zero and thus allocated. Since commit
>> 211ea740 we check for zeroness of a target page before we memset
>> it to zero. Additionally we memmap target memory so it is essentially
>> zero initialized (except for e.g. option roms and bios which are loaded
>> into target memory although they shouldn't).
>>
>> It was reported recently that this madvise causes a performance degradation
>> in some situations. As the madvise should only be called rarely and if it's called
>> it is likely on a busy page (it was non-zero and changed to zero during migration)
>> drop it completely.
> Reviewed-by: Juan Quintela <quintela@redhat.com>
>
> I take it. I am on KVM Forum/LinuxCon this week. Will send when back
> at home.
Ping
Peter
next prev parent reply other threads:[~2013-11-04 9:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 7:21 [Qemu-devel] [RESEND][PATCH] migration: drop MADVISE_DONT_NEED for incoming zero pages Peter Lieven
2013-10-24 9:14 ` [Qemu-devel] [RESEND][PATCH 1.7] " Paolo Bonzini
2013-11-18 12:48 ` Peter Lieven
2013-11-18 16:10 ` Paolo Bonzini
2013-10-24 10:07 ` [Qemu-devel] [RESEND][PATCH] " Juan Quintela
2013-11-04 9:29 ` Peter Lieven [this message]
2013-10-30 3:08 ` Zhanghaoyu (A)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527768F5.5080909@kamp.de \
--to=pl@kamp.de \
--cc=afaerber@suse.de \
--cc=haoyu.zhang@huawei.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).