From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48843) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdJEd-0001tH-2j for qemu-devel@nongnu.org; Mon, 04 Nov 2013 07:26:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdJEU-0001lQ-M9 for qemu-devel@nongnu.org; Mon, 04 Nov 2013 07:26:23 -0500 Received: from mail-qe0-x22b.google.com ([2607:f8b0:400d:c02::22b]:63319) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdJEU-0001lI-HH for qemu-devel@nongnu.org; Mon, 04 Nov 2013 07:26:14 -0500 Received: by mail-qe0-f43.google.com with SMTP id nc12so4076443qeb.30 for ; Mon, 04 Nov 2013 04:26:14 -0800 (PST) Sender: Paolo Bonzini Message-ID: <52779262.9070304@redhat.com> Date: Mon, 04 Nov 2013 13:26:10 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20131104060608.GA3322@redhat.com> In-Reply-To: <20131104060608.GA3322@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] exec: limit system memory size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Peter Maydell , marcel.a@redhat.com, Jan Kiszka , qemu-devel@nongnu.org, =?ISO-8859-1?Q?Andreas_F=E4rber?= , Richard Henderson Il 04/11/2013 07:06, Michael S. Tsirkin ha scritto: > The page table logic in exec.c assumes > that memory addresses are at most TARGET_PHYS_ADDR_SPACE_BITS. > > But pci addresses are full 64 bit so if we try to render them ignoring > the extra bits, we get strange effects with sections overlapping each > other. > > To fix, simply limit the system memory size to > 1 << TARGET_PHYS_ADDR_SPACE_BITS, > pci addresses will be rendered within that. > > Signed-off-by: Michael S. Tsirkin > --- > exec.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/exec.c b/exec.c > index 030118e..c7a8df5 100644 > --- a/exec.c > +++ b/exec.c > @@ -1801,7 +1801,12 @@ void address_space_destroy_dispatch(AddressSpace *as) > static void memory_map_init(void) > { > system_memory = g_malloc(sizeof(*system_memory)); > - memory_region_init(system_memory, NULL, "system", INT64_MAX); > + > + assert(TARGET_PHYS_ADDR_SPACE_BITS <= 64); > + > + memory_region_init(system_memory, NULL, "system", > + TARGET_PHYS_ADDR_SPACE_BITS == 64 ? > + UINT64_MAX : (0x1ULL << TARGET_PHYS_ADDR_SPACE_BITS)); > address_space_init(&address_space_memory, system_memory, "memory"); > > system_io = g_malloc(sizeof(*system_io)); > You can include either this patch or Marcel's with my Reviewed-by: Paolo Bonzini . I don't have any preference. Paolo