From: Jan Kiszka <jan.kiszka@siemens.com>
To: qemu-devel <qemu-devel@nongnu.org>,
Anthony Liguori <aliguori@us.ibm.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] rtc: remove dead SQW IRQ code
Date: Mon, 04 Nov 2013 14:30:44 +0100 [thread overview]
Message-ID: <5277A184.30305@siemens.com> (raw)
In-Reply-To: <520B6A27.4040207@siemens.com>
On 2013-08-14 13:29, Jan Kiszka wrote:
> This was once introduced by commit 100d9891d6 but was never used in-tree
> and then got broken by commit 32e0c8260d. Time to clean up.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> hw/timer/mc146818rtc.c | 9 +--------
> 1 files changed, 1 insertions(+), 8 deletions(-)
>
> diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c
> index 3c3baac..b3f1baa 100644
> --- a/hw/timer/mc146818rtc.c
> +++ b/hw/timer/mc146818rtc.c
> @@ -70,7 +70,6 @@ typedef struct RTCState {
> uint64_t last_update;
> int64_t offset;
> qemu_irq irq;
> - qemu_irq sqw_irq;
> int it_shift;
> /* periodic timer */
> QEMUTimer *periodic_timer;
> @@ -151,8 +150,7 @@ static void periodic_timer_update(RTCState *s, int64_t current_time)
>
> period_code = s->cmos_data[RTC_REG_A] & 0x0f;
> if (period_code != 0
> - && ((s->cmos_data[RTC_REG_B] & REG_B_PIE)
> - || ((s->cmos_data[RTC_REG_B] & REG_B_SQWE) && s->sqw_irq))) {
> + && (s->cmos_data[RTC_REG_B] & REG_B_PIE)) {
> if (period_code <= 2)
> period_code += 7;
> /* period in 32 Khz cycles */
> @@ -202,11 +200,6 @@ static void rtc_periodic_timer(void *opaque)
> #endif
> qemu_irq_raise(s->irq);
> }
> - if (s->cmos_data[RTC_REG_B] & REG_B_SQWE) {
> - /* Not square wave at all but we don't want 2048Hz interrupts!
> - Must be seen as a pulse. */
> - qemu_irq_raise(s->sqw_irq);
> - }
> }
>
> /* handle update-ended timer */
>
ping
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux
prev parent reply other threads:[~2013-11-04 13:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 11:29 [Qemu-devel] [PATCH] rtc: remove dead SQW IRQ code Jan Kiszka
2013-11-04 13:30 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5277A184.30305@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=aliguori@us.ibm.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).