From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34934) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdKGv-0007Zf-0R for qemu-devel@nongnu.org; Mon, 04 Nov 2013 08:32:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdKGp-0003Mf-5Y for qemu-devel@nongnu.org; Mon, 04 Nov 2013 08:32:48 -0500 Message-ID: <5277A1EB.1080107@siemens.com> Date: Mon, 04 Nov 2013 14:32:27 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1381164805-452-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <5277A0EA.8050608@siemens.com> <49782D9E-55C2-4D29-843C-46357C565127@suse.de> In-Reply-To: <49782D9E-55C2-4D29-843C-46357C565127@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] kvm: Add a new machine property kvm_type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: "list@suse.de:PReP" , Paul Mackerras , "Aneesh Kumar K.V" , QEMU Developers On 2013-11-04 14:30, Alexander Graf wrote: > > On 04.11.2013, at 14:28, Jan Kiszka wrote: > >> On 2013-10-07 18:53, Aneesh Kumar K.V wrote: >>> From: "Aneesh Kumar K.V" >>> >>> Targets like ppc64 support different typed of KVM, one which use >>> hypervisor mode and the other which doesn't. Add a new machine >>> property kvm_type that helps in selecting the respective ones >>> We also add a new QEMUMachine callback get_vm_type that helps >>> in mapping the string representation of kvm type specified. >>> >>> Signed-off-by: Aneesh Kumar K.V >> >> ... >> >>> diff --git a/vl.c b/vl.c >>> index 4e709d5..7ecc581 100644 >>> --- a/vl.c >>> +++ b/vl.c >>> @@ -427,7 +427,12 @@ static QemuOptsList qemu_machine_opts = { >>> .name = "usb", >>> .type = QEMU_OPT_BOOL, >>> .help = "Set on/off to enable/disable usb", >>> + },{ >>> + .name = "kvm_type", >>> + .type = QEMU_OPT_STRING, >>> + .help = "Set to kvm type to be used in create vm ioctl", >> >> This does not sound like an appropriate documentation for an enduser. >> >> OTOH, I do not recall right now how these help strings can be obtained >> at all. One could intuitively try "-machine ,?", but that's >> not implemented. Anyone? > > They should definitely show up in the man page. But yes, -machine kvm_type=? would be helpful as well. The man page is not generate from this C code, is it? > > As for -machine ? we are have a problem orthogonal to this patch. I agree that we need some way to programmatically list all machine options. I'm not saying that this is an issue of this patch, just that I wonder how that .help message can be made visisble at at besides with the help of an editor. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux