From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdKlu-00030F-6G for qemu-devel@nongnu.org; Mon, 04 Nov 2013 09:04:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdKln-0003aY-CQ for qemu-devel@nongnu.org; Mon, 04 Nov 2013 09:04:50 -0500 Received: from mout.web.de ([212.227.17.11]:52510) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdKln-0003Yj-2S for qemu-devel@nongnu.org; Mon, 04 Nov 2013 09:04:43 -0500 Received: from mchn199C.mchp.siemens.de ([95.157.58.223]) by smtp.web.de (mrweb102) with ESMTPSA (Nemesis) id 0LtFUV-1VnOj43KmJ-012p36 for ; Mon, 04 Nov 2013 15:04:41 +0100 Message-ID: <5277A970.4090404@web.de> Date: Mon, 04 Nov 2013 15:04:32 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <20131026090745.14894.51156.reportbug@localhost> <526B8921.3060605@msgid.tls.msk.ru> <20131026184443.7b1293d8@wiggum> <52737541.3030802@msgid.tls.msk.ru> <20131101105432.5f45f689@wiggum> <52737E08.4050908@msgid.tls.msk.ru> <5276ACBE.6030901@web.de> <5277A769.907@msgid.tls.msk.ru> In-Reply-To: <5277A769.907@msgid.tls.msk.ru> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="c2TA6cpq8xwnJfKu4oGeG5Cc3rv3Bfm7x" Subject: Re: [Qemu-devel] [PATCH] qemu: Broken -smb with latest SAMBA package. (Unsupported security=share option) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: qemu-devel This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --c2TA6cpq8xwnJfKu4oGeG5Cc3rv3Bfm7x Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2013-11-04 14:55, Michael Tokarev wrote: > 04.11.2013 00:06, Jan Kiszka wrote: >> On 2013-11-01 11:10, Michael Tokarev wrote: > [] >>> If Jan picks it up, that's fine. If not, I think it can go >>> to the trivial patches queue. >> >> Works fine, applied to queues/slirp. >=20 > Okay, thank you Jan. >=20 >> But this is not a trivial patch as the fix is not obvious for a reader= >> (unless you know smb.conf semantics by heart). >=20 > It's trivial for my understanding. If we require that every > change going to -trivial should be obvious to everyone, we > should just close it right away. Then we may need -less-trivial, because - to my understanding - -trivial was once set up according to the rule that (most) QEMU hackers should be able to understand that a trivial change is at least mostly harmless. > And this area does not have an active maintainer anyway, at least > according to MAINTAINERS and ./scripts/get_maintainer.pl. Yeah, I think we have some holes there. That smb configuration conceptually belongs to slirp is right, just not clear documented in our script. Jan --c2TA6cpq8xwnJfKu4oGeG5Cc3rv3Bfm7x Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlJ3qXYACgkQitSsb3rl5xRjFwCgmZtBhCWzgPUx3eJrC8KQi1TU q74AoJzsmVepC9w4GI3CLzStFmQ8iCFt =+Hyu -----END PGP SIGNATURE----- --c2TA6cpq8xwnJfKu4oGeG5Cc3rv3Bfm7x--