From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org,
"Stefano Stabellini" <Stefano.Stabellini@eu.citrix.com>,
"Andreas Färber" <afaerber@suse.de>,
"Anthony Liguori" <aliguori@amazon.com>,
"Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] pc: disable acpi info for isapc and old pc machine
Date: Mon, 04 Nov 2013 15:13:50 +0100 [thread overview]
Message-ID: <5277AB9E.5030903@redhat.com> (raw)
In-Reply-To: <20131104104611.GA11657@redhat.com>
Il 04/11/2013 11:46, Michael S. Tsirkin ha scritto:
> Disable acpi build for isapc and no_kvmclock machine
> types (used by xen), since acpi build currently expects pci.
>
> Reported-by: Andreas Färber <afaerber@suse.de>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Wait, Xen is not using pc_init_pci_no_kvmclock. But that's not a
problem, we can expose ACPI info via fw_cfg and then Xen hvmloader can
decide whether to use it or not. Right now it doesn't, maybe later on
it should.
If Xen is broken, we need to patch pc_xen_hvm_init, but Andreas only
tested isapc not xenfv. So unless someone reports otherwise, there is
no need to exclude ACPI info from "-M xenpv".
So my first review was wrong, but I still agree with the patch.
Paolo
next prev parent reply other threads:[~2013-11-04 14:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 10:46 [Qemu-devel] [PATCH] pc: disable acpi info for isapc and old pc machine Michael S. Tsirkin
2013-11-04 12:24 ` Paolo Bonzini
2013-11-04 20:00 ` Stefano Stabellini
2013-11-04 20:04 ` Stefano Stabellini
2013-11-04 14:13 ` Paolo Bonzini [this message]
2013-11-04 14:26 ` Michael S. Tsirkin
2013-11-04 20:06 ` Stefano Stabellini
2013-11-05 14:01 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5277AB9E.5030903@redhat.com \
--to=pbonzini@redhat.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).