From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44506)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VdKun-0001Cr-OJ
	for qemu-devel@nongnu.org; Mon, 04 Nov 2013 09:14:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VdKui-0006Tk-61
	for qemu-devel@nongnu.org; Mon, 04 Nov 2013 09:14:01 -0500
Received: from mail-qc0-x233.google.com ([2607:f8b0:400d:c01::233]:64249)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VdKuh-0006Td-Oh
	for qemu-devel@nongnu.org; Mon, 04 Nov 2013 09:13:55 -0500
Received: by mail-qc0-f179.google.com with SMTP id k18so3896563qcv.24
	for <qemu-devel@nongnu.org>; Mon, 04 Nov 2013 06:13:55 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5277AB9E.5030903@redhat.com>
Date: Mon, 04 Nov 2013 15:13:50 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20131104104611.GA11657@redhat.com>
In-Reply-To: <20131104104611.GA11657@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH] pc: disable acpi info for isapc and old pc
	machine
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>, Anthony Liguori <aliguori@amazon.com>, Eduardo Habkost <ehabkost@redhat.com>

Il 04/11/2013 11:46, Michael S. Tsirkin ha scritto:
> Disable acpi build for isapc and no_kvmclock machine
> types (used by xen), since acpi build currently expects pci.
> 
> Reported-by: Andreas Färber <afaerber@suse.de>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Wait, Xen is not using pc_init_pci_no_kvmclock.  But that's not a
problem, we can expose ACPI info via fw_cfg and then Xen hvmloader can
decide whether to use it or not.  Right now it doesn't, maybe later on
it should.

If Xen is broken, we need to patch pc_xen_hvm_init, but Andreas only
tested isapc not xenfv.  So unless someone reports otherwise, there is
no need to exclude ACPI info from "-M xenpv".

So my first review was wrong, but I still agree with the patch.

Paolo