From: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, gleb@redhat.com, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH uq/master] KVM: x86: fix typo in KVM_GET_XCRS
Date: Mon, 04 Nov 2013 16:56:04 +0100 [thread overview]
Message-ID: <5277C394.7060409@redhat.com> (raw)
In-Reply-To: <1382021272-6059-1-git-send-email-pbonzini@redhat.com>
Il 17/10/2013 16:47, Paolo Bonzini ha scritto:
> Only the first item of the array was ever looked at. No
> practical effect, but still worth fixing.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> target-i386/kvm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index 749aa09..27071e3 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -1314,8 +1314,8 @@ static int kvm_get_xcrs(X86CPU *cpu)
>
> for (i = 0; i < xcrs.nr_xcrs; i++) {
> /* Only support xcr0 now */
> - if (xcrs.xcrs[0].xcr == 0) {
> - env->xcr0 = xcrs.xcrs[0].value;
> + if (xcrs.xcrs[i].xcr == 0) {
> + env->xcr0 = xcrs.xcrs[i].value;
> break;
> }
> }
>
Ping?
next prev parent reply other threads:[~2013-11-04 15:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 14:47 [Qemu-devel] [PATCH uq/master] KVM: x86: fix typo in KVM_GET_XCRS Paolo Bonzini
2013-11-04 15:56 ` Paolo Bonzini [this message]
2013-11-05 7:34 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5277C394.7060409@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).