* [Qemu-devel] [PATCH uq/master] KVM: x86: fix typo in KVM_GET_XCRS
@ 2013-10-17 14:47 Paolo Bonzini
2013-11-04 15:56 ` Paolo Bonzini
2013-11-05 7:34 ` Gleb Natapov
0 siblings, 2 replies; 3+ messages in thread
From: Paolo Bonzini @ 2013-10-17 14:47 UTC (permalink / raw)
To: qemu-devel; +Cc: kvm, gleb
Only the first item of the array was ever looked at. No
practical effect, but still worth fixing.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target-i386/kvm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 749aa09..27071e3 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -1314,8 +1314,8 @@ static int kvm_get_xcrs(X86CPU *cpu)
for (i = 0; i < xcrs.nr_xcrs; i++) {
/* Only support xcr0 now */
- if (xcrs.xcrs[0].xcr == 0) {
- env->xcr0 = xcrs.xcrs[0].value;
+ if (xcrs.xcrs[i].xcr == 0) {
+ env->xcr0 = xcrs.xcrs[i].value;
break;
}
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH uq/master] KVM: x86: fix typo in KVM_GET_XCRS
2013-10-17 14:47 [Qemu-devel] [PATCH uq/master] KVM: x86: fix typo in KVM_GET_XCRS Paolo Bonzini
@ 2013-11-04 15:56 ` Paolo Bonzini
2013-11-05 7:34 ` Gleb Natapov
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2013-11-04 15:56 UTC (permalink / raw)
Cc: qemu-devel, gleb, kvm
Il 17/10/2013 16:47, Paolo Bonzini ha scritto:
> Only the first item of the array was ever looked at. No
> practical effect, but still worth fixing.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> target-i386/kvm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index 749aa09..27071e3 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -1314,8 +1314,8 @@ static int kvm_get_xcrs(X86CPU *cpu)
>
> for (i = 0; i < xcrs.nr_xcrs; i++) {
> /* Only support xcr0 now */
> - if (xcrs.xcrs[0].xcr == 0) {
> - env->xcr0 = xcrs.xcrs[0].value;
> + if (xcrs.xcrs[i].xcr == 0) {
> + env->xcr0 = xcrs.xcrs[i].value;
> break;
> }
> }
>
Ping?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH uq/master] KVM: x86: fix typo in KVM_GET_XCRS
2013-10-17 14:47 [Qemu-devel] [PATCH uq/master] KVM: x86: fix typo in KVM_GET_XCRS Paolo Bonzini
2013-11-04 15:56 ` Paolo Bonzini
@ 2013-11-05 7:34 ` Gleb Natapov
1 sibling, 0 replies; 3+ messages in thread
From: Gleb Natapov @ 2013-11-05 7:34 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel, kvm
On Thu, Oct 17, 2013 at 04:47:52PM +0200, Paolo Bonzini wrote:
> Only the first item of the array was ever looked at. No
> practical effect, but still worth fixing.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Applied, thanks.
> ---
> target-i386/kvm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index 749aa09..27071e3 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -1314,8 +1314,8 @@ static int kvm_get_xcrs(X86CPU *cpu)
>
> for (i = 0; i < xcrs.nr_xcrs; i++) {
> /* Only support xcr0 now */
> - if (xcrs.xcrs[0].xcr == 0) {
> - env->xcr0 = xcrs.xcrs[0].value;
> + if (xcrs.xcrs[i].xcr == 0) {
> + env->xcr0 = xcrs.xcrs[i].value;
> break;
> }
> }
> --
> 1.8.3.1
--
Gleb.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-05 7:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-17 14:47 [Qemu-devel] [PATCH uq/master] KVM: x86: fix typo in KVM_GET_XCRS Paolo Bonzini
2013-11-04 15:56 ` Paolo Bonzini
2013-11-05 7:34 ` Gleb Natapov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).