From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41137)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VdMVm-0001R5-Ri
	for qemu-devel@nongnu.org; Mon, 04 Nov 2013 10:56:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VdMVd-00031X-Kt
	for qemu-devel@nongnu.org; Mon, 04 Nov 2013 10:56:18 -0500
Received: from mail-qe0-x233.google.com ([2607:f8b0:400d:c02::233]:47097)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VdMVd-00031F-Gb
	for qemu-devel@nongnu.org; Mon, 04 Nov 2013 10:56:09 -0500
Received: by mail-qe0-f51.google.com with SMTP id q19so4148764qeb.24
	for <qemu-devel@nongnu.org>; Mon, 04 Nov 2013 07:56:08 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5277C394.7060409@redhat.com>
Date: Mon, 04 Nov 2013 16:56:04 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1382021272-6059-1-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1382021272-6059-1-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH uq/master] KVM: x86: fix typo in
	KVM_GET_XCRS
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Cc: qemu-devel@nongnu.org, gleb@redhat.com, kvm@vger.kernel.org

Il 17/10/2013 16:47, Paolo Bonzini ha scritto:
> Only the first item of the array was ever looked at.  No
> practical effect, but still worth fixing.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  target-i386/kvm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index 749aa09..27071e3 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -1314,8 +1314,8 @@ static int kvm_get_xcrs(X86CPU *cpu)
>  
>      for (i = 0; i < xcrs.nr_xcrs; i++) {
>          /* Only support xcr0 now */
> -        if (xcrs.xcrs[0].xcr == 0) {
> -            env->xcr0 = xcrs.xcrs[0].value;
> +        if (xcrs.xcrs[i].xcr == 0) {
> +            env->xcr0 = xcrs.xcrs[i].value;
>              break;
>          }
>      }
> 

Ping?