From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50434) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdOlQ-00010T-LA for qemu-devel@nongnu.org; Mon, 04 Nov 2013 13:20:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdOlL-0000nz-Pg for qemu-devel@nongnu.org; Mon, 04 Nov 2013 13:20:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:9513) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdOlL-0000nP-Hn for qemu-devel@nongnu.org; Mon, 04 Nov 2013 13:20:31 -0500 Message-ID: <5277E564.3000605@redhat.com> Date: Mon, 04 Nov 2013 11:20:20 -0700 From: Eric Blake MIME-Version: 1.0 References: <1383041545-16797-1-git-send-email-v.maffione@gmail.com> In-Reply-To: <1383041545-16797-1-git-send-email-v.maffione@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="obgfqR4TLVvOMHvlC2BdvSgARDKnGgRnM" Subject: Re: [Qemu-devel] [PATCH v3] net: Adding netmap network backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vincenzo Maffione , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, aliguori@amazon.com, mtosatti@redhat.com, mjt@tls.msk.ru, armbru@redhat.com, lcapitulino@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, g.lettieri@iet.unipi.it, rizzo@iet.unipi.it, rth@twiddle.net This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --obgfqR4TLVvOMHvlC2BdvSgARDKnGgRnM Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/29/2013 04:12 AM, Vincenzo Maffione wrote: > This patch adds support for a network backend based on netmap. > netmap is a framework for high speed packet I/O. You can use it > to build extremely fast traffic generators, monitors, software > switches or network middleboxes. Its companion software switch > VALE lets you interconnect virtual machines. > netmap and VALE are implemented as a non intrusive kernel module, > support NICs from multiple vendors, are part of standard FreeBSD > distributions and available in source format for Linux too. >=20 Looking at just the interface: > +++ b/qapi-schema.json > @@ -2984,6 +2984,22 @@ > 'hubid': 'int32' } } > =20 > ## > +# @NetdevNetmapOptions > +# > +# Connect two or more net clients through a VALE switch > +# > +# @ifname: optional name of the VALE port > +# > +# @devname: optional path of the netmap device What values are used if I omit these parameters? It's best to document what the defaults are (and if you have a hard time choosing sane defaults, it may be better to make the parameters mandatory). > +# > +# Since 1.2 This is wrong; you've already missed 1.7 freeze, so the earliest it can go in is 1.8. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --obgfqR4TLVvOMHvlC2BdvSgARDKnGgRnM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSd+VkAAoJEKeha0olJ0Nq85cH/0Kes9YQAhtsy4WlxB4HnD+b tfbHaprCRMNAByOb/Im4oezrxJUcbqJiLoh+Q3KiOeYsijwf7uhAGG5DP5qx1Bal nFODaqAvqeRv1bEGG6o+UDTdbHZxvVlOI1dlM9vEELCoYpE8SNYh1yW/O+c3Rth6 8AxW7MsZ2YL0rS7/zc+VW2vCYsabJxuyLevgfPdq+ZX0T8efOAusR2bA/071oG+5 D+17wu2Czq89TAg6uUbb43CA47ZVYCYvaZH7e7oCD27RO6+qGv7yWQOY31oRqISO nvWFFd9HLQX8lFpBmr5oIyibIiwW/7cCm9BLS4KJfmN0nVCE/zV0WPSPURwxJAU= =Tf2X -----END PGP SIGNATURE----- --obgfqR4TLVvOMHvlC2BdvSgARDKnGgRnM--