From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34551) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdPbA-00080W-2B for qemu-devel@nongnu.org; Mon, 04 Nov 2013 14:14:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdPb5-0000yN-6E for qemu-devel@nongnu.org; Mon, 04 Nov 2013 14:14:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55046) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdPb4-0000yB-TR for qemu-devel@nongnu.org; Mon, 04 Nov 2013 14:13:59 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rA4JDw1p021219 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 4 Nov 2013 14:13:58 -0500 Message-ID: <5277F1F5.7010109@redhat.com> Date: Mon, 04 Nov 2013 12:13:57 -0700 From: Eric Blake MIME-Version: 1.0 References: <1383571848-30518-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1383571848-30518-2-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qPMra7fx13okhtrSvO1G4pim6esfQccQD" Subject: Re: [Qemu-devel] [PATCH 1.7] pc: get rid of builtin pvpanic for "-M pc-1.5" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: mst@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qPMra7fx13okhtrSvO1G4pim6esfQccQD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/04/2013 06:30 AM, Paolo Bonzini wrote: > This causes two slight backwards-incompatibilities between "-M pc-1.5" > and 1.5's "-M pc": >=20 > (1) a fw_cfg file is removed with this patch. This is only a problem > if migration stops the virtual machine exactly during fw_cfg enumeratio= n. >=20 > (2) after migration, a VM created without an explicit "-device pvpanic"= > will stop reporting panics to management. >=20 > The first problem only occurs if migration is done at a very, very > early point (and I'm not sure it can happen in practice for reasonable-= size > VMs, since it will likely take more time to send the RAM to destination= , > than it will take for BIOS to scan fw_cfg). >=20 > The second problem only occurs if the guest panics _and_ has a guest > driver _and_ management knows to look at the crash event, so it is > mostly theoretical at this point in time. >=20 > Thus keep the code simple, and pretend it was never broken. >=20 > Signed-off-by: Paolo Bonzini > --- > hw/i386/pc_piix.c | 7 ------- > hw/i386/pc_q35.c | 7 ------- > hw/misc/pvpanic.c | 5 ----- > include/hw/i386/pc.h | 3 --- > 4 files changed, 22 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --qPMra7fx13okhtrSvO1G4pim6esfQccQD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSd/H1AAoJEKeha0olJ0NqP2oIAJc8rIFDV7+XH2tKOE/3KCJz bfgclsYnGv/LgAX0EK64LOBKXCoDtS5IbE4E92vAGUEgSMA80vFzRFidMRdOuveu pJGRQSmrubnr3Rzy77GS9NIevs2Z+6RwpBAd49/Xy1JrreY1x8fDT0k6gdazMpOF Xo9T7cqCXvzAd2iEqTx/f1gLCUb4Abw6K0yRJLoE+ykOj8Y7SKOdBCn7JM1SQg+B JT+k6+POmG/IrW9cquWfHn/tH8Y4/56A2JGwBQyakOZ3eT0g9mDRqcxRFLdlTAtW LEwnYCljxtnBou4bC8s40xvKstE7dZVpw1PIPG1cp2kXr2PkHqI5gFRiB2b/6uk= =tMCP -----END PGP SIGNATURE----- --qPMra7fx13okhtrSvO1G4pim6esfQccQD--