From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdeAH-0005b7-NP for qemu-devel@nongnu.org; Tue, 05 Nov 2013 05:47:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdeAB-00045C-OJ for qemu-devel@nongnu.org; Tue, 05 Nov 2013 05:47:17 -0500 Message-ID: <5278CC9C.3000308@redhat.com> Date: Tue, 05 Nov 2013 11:46:52 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1380269200-8194-1-git-send-email-aik@ozlabs.ru> <67325DB7-EF06-49CD-BA79-6B44BCC20140@suse.de> <52496601.6040500@redhat.com> <5249754E.6070308@ozlabs.ru> <5278B4FC.6020503@redhat.com> <2B4B8088-FED7-43C5-A12F-2BDDDAB2A863@suse.de> <5278BFF0.8010004@redhat.com> <5278CC3E.4040907@ozlabs.ru> In-Reply-To: <5278CC3E.4040907@ozlabs.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] spapr: add "compat" machine option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: Nikunj A Dadhania , Alexander Graf , QEMU Developers , "list@suse.de:PReP" , Paul Mackerras , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Il 05/11/2013 11:45, Alexey Kardashevskiy ha scritto: >> > Still in my opinion it should be "-cpu", not "-machine". Even if it's >> > just a "virtual" CPU model. > The compat option itself does not make much sense (yes we could just add > yet another CPU class and that's it) but with the > ibm,client-architecture-support we will have to implement this > compatibility mode anyway. Since the guest can ask for a compatibility mode > change, we either have to support compat option or hot-unplug all (all) CPU > objects in QEMU and hotplug CPUs of the requested model. Or always reset > the guest if it asked for a compatibility mode and recreate CPUs in QEMU > during reset. As for me, the compat option seems simpler. Sure, just make it a suboption of "-cpu" rather than "-machine". Paolo