From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37021) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vdf9Z-0002yZ-Sr for qemu-devel@nongnu.org; Tue, 05 Nov 2013 06:50:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vdf9U-0007jn-UZ for qemu-devel@nongnu.org; Tue, 05 Nov 2013 06:50:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:23721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vdf9U-0007ji-Le for qemu-devel@nongnu.org; Tue, 05 Nov 2013 06:50:32 -0500 Message-ID: <5278DB86.2010801@redhat.com> Date: Tue, 05 Nov 2013 04:50:30 -0700 From: Eric Blake MIME-Version: 1.0 References: <1383141276-19230-1-git-send-email-stefanha@redhat.com> <1383141276-19230-3-git-send-email-stefanha@redhat.com> In-Reply-To: <1383141276-19230-3-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="G67OnADGEbkGxQJq3VpXxeD2gOwpJ6BXQ" Subject: Re: [Qemu-devel] [PATCH v3 2/7] qdev: unref qdev when device_add fails List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Paolo Bonzini , Andreas Faerber , Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --G67OnADGEbkGxQJq3VpXxeD2gOwpJ6BXQ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/30/2013 07:54 AM, Stefan Hajnoczi wrote: > qdev_device_add() leaks the created qdev upon failure. I suspect this > problem crept in because qdev_free() unparents the qdev but does not > drop a reference - confusing name. Is it worth renaming in a future patch? >=20 > Also drop trailing whitespace after curly bracket. >=20 > Signed-off-by: Stefan Hajnoczi > --- > qdev-monitor.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --G67OnADGEbkGxQJq3VpXxeD2gOwpJ6BXQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSeNuGAAoJEKeha0olJ0NqX3wH/1g+K+NxxM8EiIL4i2jYH4O+ XawnB8lAHQ4KAUX+jhE82xO8kK6Jwwr5yOglxzvMSm5ynpjgdOviBaIQvYZxSh71 D60PxZZkJJ7UGCX0xRcOlsIKfIt+tRopMIT8+BiovBzNS7FGirPVHU4YpOie6yTb Ef73nDvqv1FtizqySHBKPGLyF7z34DUXe3V9e43S54uSP9NevNDzu39SdALn+qYB v9x+ugTQ2CTAE3ejtpuDfdLM0urgsBq2CUOE8Xg+jP4HIdbIOadcw7yFcM4TyCxa waa80nmT52ohiDFt6KvabOq6u0Fn8CSrxxkfDvZ0/7c/B38Tc3wklV2lMeaMiRI= =fzXG -----END PGP SIGNATURE----- --G67OnADGEbkGxQJq3VpXxeD2gOwpJ6BXQ--