From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdfBG-0003ri-Rn for qemu-devel@nongnu.org; Tue, 05 Nov 2013 06:52:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdfBB-0008BT-UP for qemu-devel@nongnu.org; Tue, 05 Nov 2013 06:52:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:20943) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdfBB-0008BO-Lg for qemu-devel@nongnu.org; Tue, 05 Nov 2013 06:52:17 -0500 Message-ID: <5278DBF0.7090206@redhat.com> Date: Tue, 05 Nov 2013 04:52:16 -0700 From: Eric Blake MIME-Version: 1.0 References: <1383141276-19230-1-git-send-email-stefanha@redhat.com> <1383141276-19230-4-git-send-email-stefanha@redhat.com> In-Reply-To: <1383141276-19230-4-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="V2sAiw6rhPQFpDDobhNn0rpldvlDcKRXk" Subject: Re: [Qemu-devel] [PATCH v3 3/7] libqtest: rename qmp() to qmp_discard_response() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Paolo Bonzini , Andreas Faerber , Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --V2sAiw6rhPQFpDDobhNn0rpldvlDcKRXk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/30/2013 07:54 AM, Stefan Hajnoczi wrote: > Existing qmp() callers do not expect a response object. In order to > implement real QMP test cases it will be necessary to inspect the > response object. >=20 > Rename qmp() to qmp_discard_response(). Later patches will introduce a= > qmp() function that returns the response object and tests that use it. >=20 > Signed-off-by: Stefan Hajnoczi > --- > tests/boot-order-test.c | 4 ++-- > tests/fdc-test.c | 15 +++++++++------ > tests/ide-test.c | 10 ++++++---- > tests/libqtest.c | 8 ++++---- > tests/libqtest.h | 20 ++++++++++---------- > 5 files changed, 31 insertions(+), 26 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --V2sAiw6rhPQFpDDobhNn0rpldvlDcKRXk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSeNvwAAoJEKeha0olJ0NqsbsH/iLFEOAWEF7fnlq2FFfOwhEK 7iGyBDlOxDIi0kc69KVQjPUQHaZpKZyl4OJY2RbViIOJmrV83EhJ7QwpKfonn23L 5nF5Gts1HmJlwK6II4Z3P2NlkbzPj/PfJ5PsFsyoE9p30EeJ64fQ4UYOF+9Dkkrf 8yzPFKYYmVW0G8CYBvcd6mDKkbTDKdpodAJ8C3Pa/KrKR6lahf3DnX0EOMhTGpCL +iA5U6qIlTxxHCQaOOTpRB9oL7Oa5oVPyDYCzta39KEz5lkW+Bn2tMSdcopK50Qr VsnjC8nKoxjVJG5pSuObcnDnxOhywJe27Qx9wdndpsmZ2g/0Uh2v3MRut+bd66g= =0rLU -----END PGP SIGNATURE----- --V2sAiw6rhPQFpDDobhNn0rpldvlDcKRXk--