From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdfGa-00064X-Mb for qemu-devel@nongnu.org; Tue, 05 Nov 2013 06:57:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdfGV-0001e3-Qx for qemu-devel@nongnu.org; Tue, 05 Nov 2013 06:57:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:12875) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdfGV-0001dx-Ht for qemu-devel@nongnu.org; Tue, 05 Nov 2013 06:57:47 -0500 Message-ID: <5278DD39.6030106@redhat.com> Date: Tue, 05 Nov 2013 04:57:45 -0700 From: Eric Blake MIME-Version: 1.0 References: <1383141276-19230-1-git-send-email-stefanha@redhat.com> <1383141276-19230-6-git-send-email-stefanha@redhat.com> In-Reply-To: <1383141276-19230-6-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gSk92G36aqREtCiJOOftDirkWN4eN5Aon" Subject: Re: [Qemu-devel] [PATCH v3 5/7] blockdev-test: add test case for drive_add duplicate IDs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Paolo Bonzini , Andreas Faerber , Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gSk92G36aqREtCiJOOftDirkWN4eN5Aon Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/30/2013 07:54 AM, Stefan Hajnoczi wrote: > The following should work: >=20 > (qemu) drive_add if=3Dnone,id=3Ddrive0 > (qemu) drive_del drive0 > (qemu) drive_add if=3Dnone,id=3Ddrive0 >=20 > Previous versions of QEMU produced a duplicate ID error because > drive_add leaked the options. >=20 > Signed-off-by: Stefan Hajnoczi > --- > tests/Makefile | 2 ++ > tests/blockdev-test.c | 59 +++++++++++++++++++++++++++++++++++++++++++= ++++++++ > 2 files changed, 61 insertions(+) > create mode 100644 tests/blockdev-test.c Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --gSk92G36aqREtCiJOOftDirkWN4eN5Aon Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSeN05AAoJEKeha0olJ0NqGkQIAIK/AQTIicyiXdwj7cNV7maY vYIZyKFyKWe8Ia7IfOxu0iKkM+m/+Nx+Aemr5GN7LbI9NR0YIgvrohHJj9ZREkbQ WyUVJctNzbxSlj/QHN6yFFcWyQoflVxFnwd9t5X02TKfYFfGt2kaYLRY3apnmD36 6RzvIhObRCatrINxvGH/C+2qD3x7nMW7uIBnJUxjLFZ6AozgdN7ExL+1MM8p+9qb bI1h8cMxrRLBzoBCjRNcAprEEponjhmgXP/X4GAL7mNgX0/PnNIp9HepD9e6gSSY d6yzaMZeHDZZMHkydIeISt01VvctYso4F2rs9ezPB+tikU7uH6oVgs4SJIQJLns= =MC1B -----END PGP SIGNATURE----- --gSk92G36aqREtCiJOOftDirkWN4eN5Aon--