From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39653) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdfHb-0006zR-O1 for qemu-devel@nongnu.org; Tue, 05 Nov 2013 06:59:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdfHW-0001o1-SI for qemu-devel@nongnu.org; Tue, 05 Nov 2013 06:58:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:5150) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdfHW-0001nl-Il for qemu-devel@nongnu.org; Tue, 05 Nov 2013 06:58:50 -0500 Message-ID: <5278DD78.1000402@redhat.com> Date: Tue, 05 Nov 2013 04:58:48 -0700 From: Eric Blake MIME-Version: 1.0 References: <1383141276-19230-1-git-send-email-stefanha@redhat.com> <1383141276-19230-7-git-send-email-stefanha@redhat.com> In-Reply-To: <1383141276-19230-7-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QND9t9pEA3HqM6O7IkHnu254eIrKS0buc" Subject: Re: [Qemu-devel] [PATCH v3 6/7] qdev-monitor-test: add device_add leak test cases List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Paolo Bonzini , Andreas Faerber , Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QND9t9pEA3HqM6O7IkHnu254eIrKS0buc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/30/2013 07:54 AM, Stefan Hajnoczi wrote: > Ensure that the device_add error code path deletes device objects. > Failure to do so not only leaks the objects but can also keep other > objects (like drive or netdev) alive due to qdev properties holding > references. >=20 > Signed-off-by: Stefan Hajnoczi > --- > tests/Makefile | 2 ++ > tests/qdev-monitor-test.c | 81 +++++++++++++++++++++++++++++++++++++++= ++++++++ > 2 files changed, 83 insertions(+) > create mode 100644 tests/qdev-monitor-test.c Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --QND9t9pEA3HqM6O7IkHnu254eIrKS0buc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSeN14AAoJEKeha0olJ0Nq0C4H/ReBT07Ubj0TooQGfircLC+F /dUkohzZGerMwLoekvuLcJSsXte6xeQzLaLYtWfazm+u/N29G2AlDbF9ewz85ptz 82U20ZfcYXq9JBOoiQ1Y2C2IB3EvLa5t+ZK0f3xNAq1DTXwiBmnhtqhgiAZcXTlp +1wWJu+l4ke1j1m5PRLgl3Aiww30kdeGEL6p5uVWxrFHkFjja6zmoDrCxvf0p6u+ clyIkpQ5AP8qVJztKs1iMm7J12MApoGFx0LezOTVk6M5WTK4x12HW+3ex6dvmXYO mztLPeGQKcCdXZ9njT4BJVJFj7x0YgKXh11VZzOroWZshFfQni50MH1CXOQuUN0= =P/Tc -----END PGP SIGNATURE----- --QND9t9pEA3HqM6O7IkHnu254eIrKS0buc--