From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34219) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdgW8-0000bn-DV for qemu-devel@nongnu.org; Tue, 05 Nov 2013 08:18:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdgW3-0003NE-UN for qemu-devel@nongnu.org; Tue, 05 Nov 2013 08:18:00 -0500 Message-ID: <5278F000.8060300@redhat.com> Date: Tue, 05 Nov 2013 06:17:52 -0700 From: Eric Blake MIME-Version: 1.0 References: <1383611860-9053-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1383611860-9053-2-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1383611860-9053-2-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="orPRnhNBlAWbA0f6ujfpTjd81mjqLDmwX" Subject: Re: [Qemu-devel] [PATCH RFC 01/10] qapi: fix memleak by add implict struct functions in dealloc visitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-stable@nongnu.org, armbru@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --orPRnhNBlAWbA0f6ujfpTjd81mjqLDmwX Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/04/2013 05:37 PM, Wenchao Xia wrote: s/add/adding/ in subject > Otherwise they are leaked in a qap_free_STRUCTURE() call. s/qap/qapi/ >=20 > Signed-off-by: Wenchao Xia > Cc: qemu-stable@nongnu.org > --- > qapi/qapi-dealloc-visitor.c | 20 ++++++++++++++++++++ > 1 files changed, 20 insertions(+), 0 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --orPRnhNBlAWbA0f6ujfpTjd81mjqLDmwX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSePAAAAoJEKeha0olJ0Nq8lEH/29QxIduUy0W6H1WXhGpYR97 u+4Dh0RmnEqlHiqjHOGEvJUk7BHfowXM8HXbLFDsruJrNpvj+vjrf6p7cGnSC1L0 ANBmh+vSU225UPyJgj5r0RKV/kBigiywjYdId964BkFXJcOUmNep833Dp4uiasxu sVuOYExgKjywqtaXLrEJJsXOwlxk5KBo1739TRGx7IsekDFTaUTJO6MrsbA3tHDJ izUafc54dlImpqG2m7T8TOLkrHST9u2DcA8p6vqvDCsmMeLjZHnGLbv5rjz/q7Jl USMZzunA9ptt370E1qOHWHykgjasoS6GtFb/lgIOZg3mOdllxWyWUMEaN4OS9lM= =bTAn -----END PGP SIGNATURE----- --orPRnhNBlAWbA0f6ujfpTjd81mjqLDmwX--