From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35290) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdgYM-000268-8j for qemu-devel@nongnu.org; Tue, 05 Nov 2013 08:20:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdgYH-0004Ta-B9 for qemu-devel@nongnu.org; Tue, 05 Nov 2013 08:20:18 -0500 Message-ID: <5278F087.1070400@redhat.com> Date: Tue, 05 Nov 2013 06:20:07 -0700 From: Eric Blake MIME-Version: 1.0 References: <1383611860-9053-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1383611860-9053-10-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1383611860-9053-10-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="j7HrTeuUwaHPGFrbPGohNiFd2G88UidNW" Subject: Re: [Qemu-devel] [PATCH RFC 09/10] tests: fix memleak in error path test for input visitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-stable@nongnu.org, armbru@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --j7HrTeuUwaHPGFrbPGohNiFd2G88UidNW Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/04/2013 05:37 PM, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia > Cc: qemu-stable@nongnu.org > --- > tests/test-qmp-input-visitor.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Reviewed-by: Eric Blake You should repost your mem-leak patches for qemu-stable as an independent thread marked "for-1.7", without RFC, to ensure that they are applied in a timely manner without waiting for the rest of this serie= s. >=20 > diff --git a/tests/test-qmp-input-visitor.c b/tests/test-qmp-input-visi= tor.c > index 0beb8fb..1e1c6fa 100644 > --- a/tests/test-qmp-input-visitor.c > +++ b/tests/test-qmp-input-visitor.c > @@ -604,6 +604,7 @@ static void test_visitor_in_errors(TestInputVisitor= Data *data, > g_assert(error_is_set(&errp)); > g_assert(p->string =3D=3D NULL); > =20 > + error_free(errp); > g_free(p->string); > g_free(p); > } >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --j7HrTeuUwaHPGFrbPGohNiFd2G88UidNW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSePCHAAoJEKeha0olJ0NqavEIAJ/VLPTWhOt+s+s9BM+wO384 AwhNlrMTxR4bz+tGFoizt3rDUXckTEND9XjrizURM+BTvTG3skKlWGL7rOqps5s/ bgqDtcEZY3OKx+o6nmAGFccPbOVS46b46VJhq8RSHAEdWOgTb5jossYHbqloQc+N 0UKIQhbGSi6b1SL/QJRrvlWXZOrAfUawv/MGDPa8qhfVAjYY6bszFZSEG1iZTVo/ j53aQZZT1TvQqlBbGN/ubM6V2UIAi9S50v6tiqWgGKYLxnbeJT3aO5Bga4LaXcMv 7KZbUnyQ/6zLQfF2U0kvRMrQFKI1bmZ3p1WHzCF0Ltxw9Ny+L6qv8i6I0VF8sGc= =pTzL -----END PGP SIGNATURE----- --j7HrTeuUwaHPGFrbPGohNiFd2G88UidNW--