From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vdgw0-0002oN-6B for qemu-devel@nongnu.org; Tue, 05 Nov 2013 08:44:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vdgvu-0003jn-6d for qemu-devel@nongnu.org; Tue, 05 Nov 2013 08:44:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:31194) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vdgvt-0003ji-UY for qemu-devel@nongnu.org; Tue, 05 Nov 2013 08:44:38 -0500 Message-ID: <5278F63D.9030109@redhat.com> Date: Tue, 05 Nov 2013 14:44:29 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1383610089-12168-1-git-send-email-akong@redhat.com> <1383611594-19632-1-git-send-email-akong@redhat.com> <20131105131702.GB16457@stefanha-thinkpad.redhat.com> In-Reply-To: <20131105131702.GB16457@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] iscsi: add error handling for qmp_query_uuid List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, Amos Kong , lersek@redhat.com, qemu-devel@nongnu.org Il 05/11/2013 14:17, Stefan Hajnoczi ha scritto: > On Tue, Nov 05, 2013 at 08:33:14AM +0800, Amos Kong wrote: >> We can't assume that qmp_query_uuid() always returns available value. >> >> Signed-off-by: Amos Kong >> --- >> v2: free errp if it's set >> --- >> block/iscsi.c | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) > > Reviewed-by: Stefan Hajnoczi > > I guess this will go through Paolo's SCSI tree. Actually I'm not sure this is necessary, but if people want it, it will. :) Paolo