[Qemu-devel] [PATCH] configure: Enable pie for powerpc and arm Linux

[Qemu-devel] [PATCH] configure: Enable pie for powerpc and arm Linux

[Dinar Valeev]

From: Dinar Valeev <dvaleev@suse.de>

This patch enables pie for PowerPC and ARM architectures

Signed-off-by: Dinar Valeev <dvaleev@suse.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 91372f9..0130e7e 100755
--- a/configure
+++ b/configure
@@ -1297,7 +1297,7 @@ fi
 
 if test "$pie" = ""; then
   case "$cpu-$targetos" in
-    i386-Linux|x86_64-Linux|x32-Linux|i386-OpenBSD|x86_64-OpenBSD)
+    i386-Linux|x86_64-Linux|x32-Linux|ppc*-Linux|arm*-Linux|aarch64*-Linux|i386-OpenBSD|x86_64-OpenBSD)
       ;;
     *)
       pie="no"
-- 
1.7.12.4

Re: [Qemu-devel] [PATCH] configure: Enable pie for powerpc and arm Linux

[Richard Henderson]

On 11/04/2013 10:19 PM, Dinar Valeev wrote:
> From: Dinar Valeev <dvaleev@suse.de>
> 
> This patch enables pie for PowerPC and ARM architectures
> 
> Signed-off-by: Dinar Valeev <dvaleev@suse.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 91372f9..0130e7e 100755
> --- a/configure
> +++ b/configure
> @@ -1297,7 +1297,7 @@ fi
>  
>  if test "$pie" = ""; then
>    case "$cpu-$targetos" in
> -    i386-Linux|x86_64-Linux|x32-Linux|i386-OpenBSD|x86_64-OpenBSD)
> +    i386-Linux|x86_64-Linux|x32-Linux|ppc*-Linux|arm*-Linux|aarch64*-Linux|i386-OpenBSD|x86_64-OpenBSD)

I'd much prefer that we have a blacklist than a whitelist for this.
Honestly, most ELF systems can support PIE, and we have very few
non-ELF systems to support.


r~

Re: [Qemu-devel] [PATCH] configure: Enable pie for powerpc and arm Linux

[Paolo Bonzini]

Il 04/11/2013 21:51, Richard Henderson ha scritto:
>> >  if test "$pie" = ""; then
>> >    case "$cpu-$targetos" in
>> > -    i386-Linux|x86_64-Linux|x32-Linux|i386-OpenBSD|x86_64-OpenBSD)
>> > +    i386-Linux|x86_64-Linux|x32-Linux|ppc*-Linux|arm*-Linux|aarch64*-Linux|i386-OpenBSD|x86_64-OpenBSD)
> I'd much prefer that we have a blacklist than a whitelist for this.
> Honestly, most ELF systems can support PIE, and we have very few
> non-ELF systems to support.

Since the test is followed by a compile test, we probably do not even
need the whitelist.

Paolo

Re: [Qemu-devel] [PATCH] configure: Enable pie for powerpc and arm Linux

[Andreas Färber]

Am 04.11.2013 13:19, schrieb Dinar Valeev:
> From: Dinar Valeev <dvaleev@suse.de>
> 
> This patch enables pie for PowerPC and ARM architectures
> 
> Signed-off-by: Dinar Valeev <dvaleev@suse.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 91372f9..0130e7e 100755
> --- a/configure
> +++ b/configure
> @@ -1297,7 +1297,7 @@ fi
>  
>  if test "$pie" = ""; then
>    case "$cpu-$targetos" in
> -    i386-Linux|x86_64-Linux|x32-Linux|i386-OpenBSD|x86_64-OpenBSD)
> +    i386-Linux|x86_64-Linux|x32-Linux|ppc*-Linux|arm*-Linux|aarch64*-Linux|i386-OpenBSD|x86_64-OpenBSD)
>        ;;
>      *)
>        pie="no"

For the benefit of the list, we have been using the ppc part of this
patch for the openSUSE ppc/ppc64 builds (some helper would otherwise
fail to link), and for our arm/aarch64 builds we've been using
--enable-pie to skip the above test. So those are known to work for us.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [PATCH] configure: Enable pie for powerpc and arm Linux

[Andreas Färber]

Am 04.11.2013 22:16, schrieb Paolo Bonzini:
> Il 04/11/2013 21:51, Richard Henderson ha scritto:
>>>>  if test "$pie" = ""; then
>>>>    case "$cpu-$targetos" in
>>>> -    i386-Linux|x86_64-Linux|x32-Linux|i386-OpenBSD|x86_64-OpenBSD)
>>>> +    i386-Linux|x86_64-Linux|x32-Linux|ppc*-Linux|arm*-Linux|aarch64*-Linux|i386-OpenBSD|x86_64-OpenBSD)
>> I'd much prefer that we have a blacklist than a whitelist for this.
>> Honestly, most ELF systems can support PIE, and we have very few
>> non-ELF systems to support.
> 
> Since the test is followed by a compile test, we probably do not even
> need the whitelist.

I remember reading a report here that someone ran into a link issue with
PIE on x86 at build time (check went okay) and was able to resolve it
via --disable-pie. Unfortunately I couldn't locate the post - do you
remember what that was about? Was that some BSD rather than Linux maybe?

It's probably a good idea to still allow overriding it, whether we
white- or blacklist or trust a compile test.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg