From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53717) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdldA-0003AR-6N for qemu-devel@nongnu.org; Tue, 05 Nov 2013 13:45:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vdld5-00017c-7C for qemu-devel@nongnu.org; Tue, 05 Nov 2013 13:45:36 -0500 Received: from cantor2.suse.de ([195.135.220.15]:37764 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vdld4-000175-SA for qemu-devel@nongnu.org; Tue, 05 Nov 2013 13:45:31 -0500 Message-ID: <52793CC6.8060101@suse.de> Date: Tue, 05 Nov 2013 19:45:26 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1382385786-9178-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-1.7] configure: Explicitly set ARFLAGS so we can build with GNU Make 4.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , QEMU Developers Cc: Ken Moffat , Anthony Liguori , Patch Tracking Am 05.11.2013 19:04, schrieb Peter Maydell: > Ping! A typo in the commit message has been reported, and it has been requested to add Cc: qemu-stable@nongnu.org. Since you neither CC qemu-trivial nor a particular maintainer that would fix those for you, you'll have to respin. Andreas >=20 > thanks > -- PMM >=20 > On 21 October 2013 21:03, Peter Maydell wrot= e: >> Our rules.mak adds '-rR' to MAKEFLAGS to indicate that we will be >> explicitly specifying everything and not relying on any default >> variables or rules. However we were accidentally relying on the >> default ARFLAGS ("rv"). This went unnoticed because of a bug in >> GNU Make 3.82 and earlier which meant that adding -rR to MAKEFLAGS >> only affected submakes, not the currently running instance. >> Explicitly set ARFLAGS in config-host.mak, in the same way we >> handle CFLAGS and LDFLAGS; this will allow us to work with >> Make 4.0. >> >> Thanks to Paul Smith for analyzing this bug for us. >> >> Reported-by: Ken Moffat >> Signed-off-by: Peter Maydell >> --- >> Ken: I think this should work (and it doesn't break building with >> old makes), but I don't have a make 4.0 to hand; if you could >> test it I'd appreciate it. >> >> configure | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/configure b/configure >> index 57ee62a..4eb3a07 100755 >> --- a/configure >> +++ b/configure >> @@ -308,6 +308,9 @@ query_pkg_config() { >> pkg_config=3Dquery_pkg_config >> sdl_config=3D"${SDL_CONFIG-${cross_prefix}sdl-config}" >> >> +# If the user hasn't specified ARFLAGS, default to 'rv', just as make= does. >> +ARFLAGS=3D"${ARFLAGS-rv}" >> + >> # default flags for all hosts >> QEMU_CFLAGS=3D"-fno-strict-aliasing $QEMU_CFLAGS" >> QEMU_CFLAGS=3D"-Wall -Wundef -Wwrite-strings -Wmissing-prototypes $QE= MU_CFLAGS" >> @@ -3664,6 +3667,7 @@ echo "C compiler $cc" >> echo "Host C compiler $host_cc" >> echo "C++ compiler $cxx" >> echo "Objective-C compiler $objcc" >> +echo "ARFLAGS $ARFLAGS" >> echo "CFLAGS $CFLAGS" >> echo "QEMU_CFLAGS $QEMU_CFLAGS" >> echo "LDFLAGS $LDFLAGS" >> @@ -4239,6 +4243,7 @@ echo "HOST_CC=3D$host_cc" >> $config_host_mak >> echo "CXX=3D$cxx" >> $config_host_mak >> echo "OBJCC=3D$objcc" >> $config_host_mak >> echo "AR=3D$ar" >> $config_host_mak >> +echo "ARFLAGS=3D$ARFLAGS" >> $config_host_mak >> echo "AS=3D$as" >> $config_host_mak >> echo "CPP=3D$cpp" >> $config_host_mak >> echo "OBJCOPY=3D$objcopy" >> $config_host_mak >> -- >> 1.7.11.4 >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg