From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdlxJ-0002ug-AR for qemu-devel@nongnu.org; Tue, 05 Nov 2013 14:06:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdlxD-0007hg-Ei for qemu-devel@nongnu.org; Tue, 05 Nov 2013 14:06:25 -0500 Received: from mail-pd0-x22a.google.com ([2607:f8b0:400e:c02::22a]:56941) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdlxD-0007gc-6u for qemu-devel@nongnu.org; Tue, 05 Nov 2013 14:06:19 -0500 Received: by mail-pd0-f170.google.com with SMTP id v10so9001269pde.15 for ; Tue, 05 Nov 2013 11:06:17 -0800 (PST) Sender: Richard Henderson Message-ID: <5279419B.3000906@twiddle.net> Date: Wed, 06 Nov 2013 05:06:03 +1000 From: Richard Henderson MIME-Version: 1.0 References: <1383669517-25598-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1383669517-25598-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/9] Remove legacy unaligned bswap functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: Kevin Wolf , "Michael S. Tsirkin" , Stefan Hajnoczi , Anthony Liguori , patches@linaro.org On 11/06/2013 02:38 AM, Peter Maydell wrote: > This is a simple resend of a patchset which has been > on the list reviewed but unapplied for nine weeks, since > it's probably fallen out of Anthony's patches cache. > > > The bswap.h header includes a set of "legacy unaligned functions" > that (since commit c732a52d3 at the beginning of this year) are > just wrappers for underlying {ld,st} functions. The legacy > functions aren't used in many places, so just replace all their > uses with uses of the new-style {ld,st} functions; this lets us > remove the legacy wrappers altogether. > > Since we know the {ld,st}* routines are definitely functions, > we can in the process remove some casts which were left over > from when the legacy unaligned functions were previously macros. > > The patchset is divided up by function being removed, rather > than by which device/subsystem is being fixed; I think this way > round is easier to review since you only have to keep one > substitution in your head when reading a patch. > > Peter Maydell (9): > bswap.h: Remove cpu_to_le16wu() > bswap.h: Remove cpu_to_le32wu() > bswap.h: Remove le16_to_cpupu() > bswap.h: Remove le32_to_cpupu() > bswap.h: Remove be32_to_cpupu() > bswap.h: Remove cpu_to_be16wu() > bswap.h: Remove cpu_to_be32wu() > bswap.h: Remove cpu_to_be64wu() > bswap.h: Remove cpu_to_32wu() Reviewed-by: Richard Henderson ... again. > > block/qcow2-cluster.c | 2 +- > hw/acpi/core.c | 3 +-- > hw/block/cdrom.c | 10 +++++----- > hw/display/vga_template.h | 14 ++++++++------ > hw/ide/atapi.c | 16 +++++++-------- > hw/net/e1000.c | 22 +++++++++------------ > hw/net/ne2000.c | 4 ++-- > hw/pci/pcie_aer.c | 4 ++-- > include/hw/pci/pci.h | 8 ++++---- > include/qemu/bswap.h | 47 --------------------------------------------- > 10 files changed, 40 insertions(+), 90 deletions(-) >