From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vdshm-0004xv-DF for qemu-devel@nongnu.org; Tue, 05 Nov 2013 21:18:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdshX-00065j-Ly for qemu-devel@nongnu.org; Tue, 05 Nov 2013 21:18:50 -0500 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:47646) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdshW-00065J-UG for qemu-devel@nongnu.org; Tue, 05 Nov 2013 21:18:35 -0500 Received: from /spool/local by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 6 Nov 2013 12:18:14 +1000 Message-ID: <5279A6E2.1020101@linux.vnet.ibm.com> Date: Wed, 06 Nov 2013 10:18:10 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1383611860-9053-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1383611860-9053-10-git-send-email-xiawenc@linux.vnet.ibm.com> <5278F087.1070400@redhat.com> In-Reply-To: <5278F087.1070400@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH RFC 09/10] tests: fix memleak in error path test for input visitor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, qemu-stable@nongnu.org, armbru@redhat.com 于 2013/11/5 21:20, Eric Blake 写道: > On 11/04/2013 05:37 PM, Wenchao Xia wrote: >> Signed-off-by: Wenchao Xia >> Cc: qemu-stable@nongnu.org >> --- >> tests/test-qmp-input-visitor.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) > > Reviewed-by: Eric Blake > > You should repost your mem-leak patches for qemu-stable as an > independent thread marked "for-1.7", without RFC, to ensure that they > are applied in a timely manner without waiting for the rest of this series. > OK, will resend. >> >> diff --git a/tests/test-qmp-input-visitor.c b/tests/test-qmp-input-visitor.c >> index 0beb8fb..1e1c6fa 100644 >> --- a/tests/test-qmp-input-visitor.c >> +++ b/tests/test-qmp-input-visitor.c >> @@ -604,6 +604,7 @@ static void test_visitor_in_errors(TestInputVisitorData *data, >> g_assert(error_is_set(&errp)); >> g_assert(p->string == NULL); >> >> + error_free(errp); >> g_free(p->string); >> g_free(p); >> } >> >