qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Cole Robinson <crobinso@redhat.com>
Cc: qemu-trivial@nongnu.org, alex.williamson@redhat.com,
	mst@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] pci-assign: Fix error_report of pci-stub message
Date: Wed, 06 Nov 2013 12:44:38 +0400	[thread overview]
Message-ID: <527A0176.1030708@msgid.tls.msk.ru> (raw)
In-Reply-To: <5279838F.8060008@redhat.com>

> On 10/11/2013 11:52 AM, Cole Robinson wrote:
>> Using multiple calls to error_report here means every line is
>> prefaced with the (potentially long) pci-assign command line
>> arguments.
>>
>> Use a single error_printf to preserve the intended formatting.
>> Since this code path is always preceded by an error_report call,
>> we don't lose the command line reporting.

Thanks, applied to the trivial-patches queue.

/mjt

      reply	other threads:[~2013-11-06  8:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-11 15:52 [Qemu-devel] [PATCH v2] pci-assign: Fix error_report of pci-stub message Cole Robinson
2013-10-14  6:47 ` Markus Armbruster
2013-11-05 23:47 ` Cole Robinson
2013-11-06  8:44   ` Michael Tokarev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=527A0176.1030708@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=alex.williamson@redhat.com \
    --cc=armbru@redhat.com \
    --cc=crobinso@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).