From: Paolo Bonzini <pbonzini@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: aarcange@redhat.com, Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, gleb@redhat.com,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] i386: pc: align gpa<->hpa on 1GB boundary (v3)
Date: Wed, 06 Nov 2013 13:24:08 +0100 [thread overview]
Message-ID: <527A34E8.2030502@redhat.com> (raw)
In-Reply-To: <20131106132202.4a7080d3@nial.usersys.redhat.com>
Il 06/11/2013 13:22, Igor Mammedov ha scritto:
>>> > > 'gb_align' is one shot usage, it would be better to just add it as an argument
>>> > > to pc_memory_init(). That would allow to avoid extending PcGuestInfo needlessly,
>>> > > since gb_align isn't reused.
>> >
>> > No, Marcelo's way is better. pc_memory_init already has too many
>> > arguments, moving them to PcGuestInfo (which ultimately might become
>> > properties of the /machine QOM object) is the right thing to do.
> In general I agree. But unless there is plans to reuse gb_align in future,
The plan is to turn it (and also has_acpi_build etc.) into a global
property that can be set using the usual compat-property machinery.
> it doesn't really belong to PcGuestInfo (this change however looks like
> cannibalizing structure for argument passing only).
For now, it doesn't just look like that, it is like that. :) But it is
still a step in the right direction.
Paolo
next prev parent reply other threads:[~2013-11-06 12:24 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 21:11 [Qemu-devel] [patch 0/2] align >4GB guest RAM to a 1GB boundary, in case of 1GB-sized hugetlbfs Marcelo Tosatti
2013-10-24 21:11 ` [Qemu-devel] [patch 1/2] exec: add qemu_get_ram_hpagesize Marcelo Tosatti
2013-10-24 21:12 ` [Qemu-devel] [patch 2/2] i386: pc: align gpa<->hpa on 1GB boundary Marcelo Tosatti
2013-10-24 21:55 ` Peter Maydell
2013-10-24 22:48 ` Marcelo Tosatti
2013-10-24 23:55 ` Paolo Bonzini
2013-10-25 4:58 ` Marcelo Tosatti
2013-10-25 8:52 ` Paolo Bonzini
2013-10-25 19:50 ` Marcelo Tosatti
2013-10-25 22:53 ` Paolo Bonzini
2013-10-30 11:07 ` Gerd Hoffmann
2013-10-30 11:47 ` Paolo Bonzini
2013-10-25 9:57 ` igor Mammedov
2013-10-25 13:34 ` Marcelo Tosatti
2013-10-27 15:20 ` igor Mammedov
2013-10-28 14:04 ` Marcelo Tosatti
2013-10-28 14:20 ` Marcelo Tosatti
2013-10-29 18:00 ` Igor Mammedov
2013-10-29 21:21 ` Marcelo Tosatti
2013-10-30 8:48 ` Gleb Natapov
2013-10-30 18:30 ` Marcelo Tosatti
2013-10-29 18:18 ` [Qemu-devel] [RFC PATCH] pc: align gpa<->hpa on 1GB boundary by splitting RAM on several regions Igor Mammedov
2013-10-29 21:38 ` Marcelo Tosatti
2013-10-30 16:49 ` Igor Mammedov
2013-10-30 18:51 ` Marcelo Tosatti
2013-10-30 19:03 ` Marcelo Tosatti
2013-10-30 19:56 ` Igor Mammedov
2013-10-30 23:44 ` Marcelo Tosatti
2013-11-07 15:25 ` Igor Mammedov
2013-10-30 19:31 ` Marcelo Tosatti
2013-10-30 20:28 ` Paolo Bonzini
2013-11-06 1:49 ` [Qemu-devel] i386: pc: align gpa<->hpa on 1GB boundary (v2) Marcelo Tosatti
2013-11-06 1:55 ` [Qemu-devel] i386: pc: align gpa<->hpa on 1GB boundary (v3) Marcelo Tosatti
2013-11-06 11:59 ` Igor Mammedov
2013-11-06 12:07 ` Paolo Bonzini
2013-11-06 12:22 ` Igor Mammedov
2013-11-06 12:24 ` Paolo Bonzini [this message]
2013-11-06 21:31 ` [Qemu-devel] i386: pc: align gpa<->hpa on 1GB boundary (v4) Marcelo Tosatti
2013-11-06 21:40 ` Michael S. Tsirkin
2013-11-06 21:53 ` Marcelo Tosatti
2013-11-06 22:15 ` Michael S. Tsirkin
2013-11-06 22:24 ` Marcelo Tosatti
2013-11-07 15:24 ` Igor Mammedov
2013-11-07 21:53 ` Marcelo Tosatti
2013-11-10 20:47 ` [Qemu-devel] i386: pc: align gpa<->hpa on 1GB boundary (v5) Marcelo Tosatti
2013-11-12 12:45 ` Igor Mammedov
2013-11-12 20:32 ` Marcelo Tosatti
2013-11-12 21:16 ` [Qemu-devel] i386: pc: align gpa<->hpa on 1GB boundary (v6) Marcelo Tosatti
2013-11-13 13:59 ` Igor Mammedov
2013-11-13 17:13 ` Paolo Bonzini
[not found] ` <20131113195832.GA29433@amt.cnet>
2013-11-13 20:39 ` Marcelo Tosatti
2013-11-13 21:49 ` Paolo Bonzini
2013-11-13 19:08 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527A34E8.2030502@redhat.com \
--to=pbonzini@redhat.com \
--cc=aarcange@redhat.com \
--cc=gleb@redhat.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).