From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ve29j-000490-8o for qemu-devel@nongnu.org; Wed, 06 Nov 2013 07:24:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ve29d-0007rt-98 for qemu-devel@nongnu.org; Wed, 06 Nov 2013 07:24:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:62179) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ve29d-0007ri-0j for qemu-devel@nongnu.org; Wed, 06 Nov 2013 07:24:13 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rA6COCpX026599 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 6 Nov 2013 07:24:12 -0500 Message-ID: <527A34E8.2030502@redhat.com> Date: Wed, 06 Nov 2013 13:24:08 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20131024211158.064049176@amt.cnet> <20131024211249.723543071@amt.cnet> <20131106014930.GA20468@amt.cnet> <20131106015543.GA20766@amt.cnet> <20131106125930.3be6fb4e@nial.usersys.redhat.com> <527A30FE.2070107@redhat.com> <20131106132202.4a7080d3@nial.usersys.redhat.com> In-Reply-To: <20131106132202.4a7080d3@nial.usersys.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] i386: pc: align gpa<->hpa on 1GB boundary (v3) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: aarcange@redhat.com, Marcelo Tosatti , qemu-devel@nongnu.org, gleb@redhat.com, Gerd Hoffmann Il 06/11/2013 13:22, Igor Mammedov ha scritto: >>> > > 'gb_align' is one shot usage, it would be better to just add it as an argument >>> > > to pc_memory_init(). That would allow to avoid extending PcGuestInfo needlessly, >>> > > since gb_align isn't reused. >> > >> > No, Marcelo's way is better. pc_memory_init already has too many >> > arguments, moving them to PcGuestInfo (which ultimately might become >> > properties of the /machine QOM object) is the right thing to do. > In general I agree. But unless there is plans to reuse gb_align in future, The plan is to turn it (and also has_acpi_build etc.) into a global property that can be set using the usual compat-property machinery. > it doesn't really belong to PcGuestInfo (this change however looks like > cannibalizing structure for argument passing only). For now, it doesn't just look like that, it is like that. :) But it is still a step in the right direction. Paolo