From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34553) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ve3W7-0005Bw-K0 for qemu-devel@nongnu.org; Wed, 06 Nov 2013 08:51:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ve3W2-0000GQ-Gz for qemu-devel@nongnu.org; Wed, 06 Nov 2013 08:51:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41947) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ve3W2-0000GI-7v for qemu-devel@nongnu.org; Wed, 06 Nov 2013 08:51:26 -0500 Message-ID: <527A495B.8010101@redhat.com> Date: Wed, 06 Nov 2013 06:51:23 -0700 From: Eric Blake MIME-Version: 1.0 References: <1383734545-20403-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1383734545-20403-1-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Xi6vKSimu3BfupGtVnap5s90J9ulsfoDx" Subject: Re: [Qemu-devel] [PATCH v2 1.7] pc: get rid of builtin pvpanic for "-M pc-1.5" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: anthony@codemonkey.ws This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Xi6vKSimu3BfupGtVnap5s90J9ulsfoDx Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/06/2013 03:42 AM, Paolo Bonzini wrote: > This causes two slight backwards-incompatibilities between "-M pc-1.5" > and 1.5's "-M pc": >=20 > (1) a fw_cfg file is removed with this patch. This is only a problem > if migration stops the virtual machine exactly during fw_cfg enumeratio= n. >=20 > (2) after migration, a VM created without an explicit "-device pvpanic"= > will stop reporting panics to management. >=20 > The first problem only occurs if migration is done at a very, very > early point (and I'm not sure it can happen in practice for reasonable-= size > VMs, since it will likely take more time to send the RAM to destination= , > than it will take for BIOS to scan fw_cfg). >=20 > The second problem only occurs if the guest panics _and_ has a guest > driver _and_ management knows to look at the crash event, so it is > mostly theoretical at this point in time. >=20 > Thus keep the code simple, and pretend it was never broken. >=20 > Signed-off-by: Paolo Bonzini > --- > hw/i386/pc_piix.c | 7 ------- > hw/i386/pc_q35.c | 7 ------- > hw/misc/pvpanic.c | 5 ----- > include/hw/i386/pc.h | 1 - > 4 files changed, 20 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Xi6vKSimu3BfupGtVnap5s90J9ulsfoDx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSeklbAAoJEKeha0olJ0NqmhYH/iTrdQLssgaYHeiXYq+eDhrm 8Z5MQCF84AECQDtvGQnCaYvA4P2X2ZdhePZM99I6Us+SKIZ/KpEjZfkzEo9Iniot hl50NUqlkWeULKHdQibcrkVpuNhfMXKzEZcMBX0wlgQwY9SmclUsStiKgEvZHNwr HKL9OSGXnLyOv7VoSASvKGsPvuX2GSowegBg+6x9/yUpjXGhNdSKeiliyhwj7IU9 H56zHo29Nu3xCz6Bqx0Ayxrg6+3tyWaBePILGnKR4WBwcOQwcMTtuueVr+Hjs0wY Bp5fDR44I5ZxZ/1JeOqKZsX7Rd74H5OMjcj/A6/yp7hYEx8kVbNY/503fwOZJco= =1C+R -----END PGP SIGNATURE----- --Xi6vKSimu3BfupGtVnap5s90J9ulsfoDx--