From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35750)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Ve5VY-00048N-SP
	for qemu-devel@nongnu.org; Wed, 06 Nov 2013 10:59:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Ve5VO-0000NJ-4J
	for qemu-devel@nongnu.org; Wed, 06 Nov 2013 10:59:04 -0500
Received: from mail-qe0-x230.google.com ([2607:f8b0:400d:c02::230]:57355)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Ve5VO-0000NF-05
	for qemu-devel@nongnu.org; Wed, 06 Nov 2013 10:58:54 -0500
Received: by mail-qe0-f48.google.com with SMTP id d4so6312305qej.21
	for <qemu-devel@nongnu.org>; Wed, 06 Nov 2013 07:58:53 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <527A6739.50400@redhat.com>
Date: Wed, 06 Nov 2013 16:58:49 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1383743088-8139-1-git-send-email-quintela@redhat.com>
	<1383743088-8139-38-git-send-email-quintela@redhat.com>
In-Reply-To: <1383743088-8139-38-git-send-email-quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 37/39] memory: syncronize kvm bitmap using
	bitmaps operations
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: chegu_vinod@hp.com, qemu-devel@nongnu.org

Il 06/11/2013 14:04, Juan Quintela ha scritto:
> +    /* start address is aligned at the start of a word? */
> +    if (((page * BITS_PER_LONG) << TARGET_PAGE_BITS) == start) {
> +        int k;
> +        int nr = BITS_TO_LONGS(pages);
> +
> +        printf("XXX: aligned start %lx page %lx\n", start, page);
> +        assert(start == ((start >> TARGET_PAGE_BITS) << TARGET_PAGE_BITS));

This test is useless, since you have already tested the zero-ness of the
low bits in the "if" condition: the low bits are 0 in ((page *
BITS_PER_LONG) << TARGET_PAGE_BITS).

Paolo