From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ve5jS-00049w-QJ for qemu-devel@nongnu.org; Wed, 06 Nov 2013 11:13:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ve5jN-0005hJ-Te for qemu-devel@nongnu.org; Wed, 06 Nov 2013 11:13:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ve5jN-0005hA-LU for qemu-devel@nongnu.org; Wed, 06 Nov 2013 11:13:21 -0500 Message-ID: <527A6A9D.80009@redhat.com> Date: Wed, 06 Nov 2013 09:13:17 -0700 From: Eric Blake MIME-Version: 1.0 References: <1383748741-8865-1-git-send-email-coreyb@linux.vnet.ibm.com> In-Reply-To: <1383748741-8865-1-git-send-email-coreyb@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="St9oFfRLxFQCcsF5P2flQ45hUaqdQ0sPH" Subject: Re: [Qemu-devel] [PATCH 3/4] tpm: QMP/HMP support for libtpms TPM backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corey Bryant , qemu-devel@nongnu.org Cc: aliguori@amazon.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --St9oFfRLxFQCcsF5P2flQ45hUaqdQ0sPH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/06/2013 07:39 AM, Corey Bryant wrote: [your git settings are odd; your messages came across as individual threads rather than in-reply to the cover letter] > This patch provides HMP 'info tpm', QMP 'query-tpm' and QMP > 'query-tpm-types' support for the libtpms TPM backend. >=20 > Signed-off-by: Corey Bryant > --- > hmp.c | 5 +++++ > include/sysemu/tpm_backend.h | 1 + > qapi-schema.json | 18 ++++++++++++++++-- > tpm.c | 7 +++++++ > 4 files changed, 29 insertions(+), 2 deletions(-) >=20 > +++ b/qapi-schema.json > @@ -3673,10 +3673,11 @@ > # An enumeration of TPM types > # > # @passthrough: TPM passthrough type > +# @libtpms: TPM libtpms type Worth adding '(since 1.8)' to mark when this enum value was added. > # @TpmTypeOptions: > # > # A union referencing different TPM backend types' configuration optio= ns > # > # @passthrough: The configuration options for the TPM passthrough type= > +# @libtpms: The configuration options for the TPM libtpms type here as well. > # > # Since: 1.5 > ## > { 'union': 'TpmTypeOptions', > - 'data': { 'passthrough' : 'TPMPassthroughOptions' } } > + 'data': { 'passthrough' : 'TPMPassthroughOptions', > + 'libtpms' : 'TPMLibtpmsOptions' } } > =20 Otherwise it looks okay to me. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --St9oFfRLxFQCcsF5P2flQ45hUaqdQ0sPH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSemqdAAoJEKeha0olJ0NqHUAH/i5e4NpvhUdZwo5q97HqTNhX VcR6z2Mo/Cmmjd617tORZjgfA5CwNfZSwJm4Z8bKnNKs7gmsCNcDL7JGmY53BaGE xuZwnQ3vufN1JS+VmGh0ioR8GYTj6+4dR1xVjrJk3WB6xksftTrz3zla+YG8ZaFW m47GFTv6HePDmGD77l0NkVUPYjK+1cwuB77inesfM5Yjjn1QiStxxbKH0aHDXhGX MRpBexlgZ0/1zk/U+W9EJQ7sH3ezClPOqbCA6QYE8QDU+Yh2w99GE0RI8jGBANPh 8Y+57A6bXnDrZ0n/RKS/Bcr+63Amx0Y1xVQK4j/9tiRyFisghsU6AJk1o5rfApU= =hnuC -----END PGP SIGNATURE----- --St9oFfRLxFQCcsF5P2flQ45hUaqdQ0sPH--