From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52869) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ve8Yh-00071D-9u for qemu-devel@nongnu.org; Wed, 06 Nov 2013 14:14:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ve8Yb-0005DX-BR for qemu-devel@nongnu.org; Wed, 06 Nov 2013 14:14:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51129) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ve8Yb-0005Cp-3U for qemu-devel@nongnu.org; Wed, 06 Nov 2013 14:14:25 -0500 Message-ID: <527A9509.80808@redhat.com> Date: Wed, 06 Nov 2013 20:14:17 +0100 From: Max Reitz MIME-Version: 1.0 References: <1383609689-4417-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1383609689-4417-2-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1383609689-4417-2-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V5 1/6] snapshot: add parameter *errp in snapshot create List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@gmail.com On 05.11.2013 01:01, Wenchao Xia wrote: > The return value is only used for error report before this patch, > so change the function protype to return void. > > Signed-off-by: Wenchao Xia > --- > block/qcow2-snapshot.c | 30 +++++++++++++++++++++++++----- > block/qcow2.h | 4 +++- > block/rbd.c | 19 ++++++++++--------- > block/sheepdog.c | 28 ++++++++++++++++++---------- > block/snapshot.c | 19 +++++++++++++------ > blockdev.c | 10 ++++------ > include/block/block_int.h | 5 +++-- > include/block/snapshot.h | 5 +++-- > qemu-img.c | 10 ++++++---- > savevm.c | 12 ++++++++---- > 10 files changed, 93 insertions(+), 49 deletions(-) Reviewed-by: Max Reitz