From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52949) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ve8ZA-0007W7-Ta for qemu-devel@nongnu.org; Wed, 06 Nov 2013 14:15:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ve8Z4-0005g6-Uv for qemu-devel@nongnu.org; Wed, 06 Nov 2013 14:15:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33303) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ve8Z4-0005fv-NR for qemu-devel@nongnu.org; Wed, 06 Nov 2013 14:14:54 -0500 Message-ID: <527A9527.1060508@redhat.com> Date: Wed, 06 Nov 2013 20:14:47 +0100 From: Max Reitz MIME-Version: 1.0 References: <1383609689-4417-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1383609689-4417-3-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1383609689-4417-3-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V5 2/6] qcow2: add error message in qcow2_write_snapshots() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@gmail.com On 05.11.2013 01:01, Wenchao Xia wrote: > The function still returns int since qcow2_snapshot_delete() will > return the number. > > Signed-off-by: Wenchao Xia > --- > block/qcow2-snapshot.c | 43 +++++++++++++++++++++++++++++++++++++------ > 1 files changed, 37 insertions(+), 6 deletions(-) Reviewed-by: Max Reitz