From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36223) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ve9WL-0004T4-B0 for qemu-devel@nongnu.org; Wed, 06 Nov 2013 15:16:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ve9WC-0007DL-T1 for qemu-devel@nongnu.org; Wed, 06 Nov 2013 15:16:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:30402) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ve9WC-0007C3-Hg for qemu-devel@nongnu.org; Wed, 06 Nov 2013 15:16:00 -0500 Message-ID: <527AA37A.7090801@redhat.com> Date: Wed, 06 Nov 2013 13:15:54 -0700 From: Eric Blake MIME-Version: 1.0 References: <1383748741-8865-1-git-send-email-coreyb@linux.vnet.ibm.com> <527A6A9D.80009@redhat.com> <527A9A1F.9090509@linux.vnet.ibm.com> In-Reply-To: <527A9A1F.9090509@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kx8N8TeWjmWO1h5lCqPs3w3bp2fhAJi59" Subject: Re: [Qemu-devel] [PATCH 3/4] tpm: QMP/HMP support for libtpms TPM backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corey Bryant , qemu-devel@nongnu.org Cc: aliguori@amazon.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kx8N8TeWjmWO1h5lCqPs3w3bp2fhAJi59 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/06/2013 12:35 PM, Corey Bryant wrote: >>> # >>> # Since: 1.5 >>> ## >>> { 'union': 'TpmTypeOptions', >>> - 'data': { 'passthrough' : 'TPMPassthroughOptions' } } >>> + 'data': { 'passthrough' : 'TPMPassthroughOptions', >>> + 'libtpms' : 'TPMLibtpmsOptions' } } >>> >> >> Otherwise it looks okay to me. >> >=20 > Thanks for the comments. I'll add them to the next version. Can I add= > your Reviewed-by to this patch? Yes, now that I've looked at the full patch (and not just the .json): Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --kx8N8TeWjmWO1h5lCqPs3w3bp2fhAJi59 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSeqN7AAoJEKeha0olJ0NqNIAH+wcNMCt7uISEfUXht6l1jlU5 JkI18EaV/88A9cUQYWNnndvk+HAExfJ9CgbJ+o8K63MCZgO6inN0Sd57SjwsFbLU QOnyNCjGwFCvmMGW3PBGBoBf2LP9CgjTU8lFufopo9T/t/2t5gJJ7E1e+VR+LDp4 6ipPYXuHvfOp3CyNISD4o0yRkQ2mrd5HkAdGXCLTdynSseE/tA2kZalrc0P+Vp4p JYimlp6tm6R6e32yA8oNZZeXdHawPAHToUdGjOJ5ems7f7ZMc2OeD5CVXgE60Cci /+esR5SlwE7x5UMhvZ2HG3CqNN8ORb2ouhrOJbURO6fIvEa0IW5a+eIkitncswE= =SALy -----END PGP SIGNATURE----- --kx8N8TeWjmWO1h5lCqPs3w3bp2fhAJi59--