From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
marcel.a@redhat.com
Subject: Re: [Qemu-devel] BUG: QEMU aborts when setting breakpoint in gdb (bisected)
Date: Wed, 06 Nov 2013 22:13:16 +0100 [thread overview]
Message-ID: <527AB0EC.8080200@redhat.com> (raw)
In-Reply-To: <20131106183912.GA16747@redhat.com>
Il 06/11/2013 19:39, Michael S. Tsirkin ha scritto:
> Because this will affect performance in unpredicatable way.
It's not really unpredictable. It can be easily unit-tested, and anyway
the targets with 64-bit address spaces don't have any particular
performance problem.
> We can't make such changes in 1.7 IMHO:
> it would need much more than just a quick "works for me".
I can say the same about phys_page_find. It's been obviously broken for
years and nobody ever cared, it cannot be super-urgent now to fix it.
Paolo
>> > I don't feel confident
>> > changing phys_page_find, even if it's just 2 lines.
>> >
>> > Paolo
> Well it's *obviously* broken if address is outside target address
> space.
> Take a look at the patch first, then argue.
next prev parent reply other threads:[~2013-11-06 21:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 16:22 [Qemu-devel] BUG: QEMU aborts when setting breakpoint in gdb (bisected) Luiz Capitulino
2013-11-06 16:26 ` Paolo Bonzini
2013-11-06 16:29 ` Luiz Capitulino
2013-11-06 16:33 ` Michael S. Tsirkin
2013-11-06 16:30 ` Marcel Apfelbaum
2013-11-06 17:39 ` Paolo Bonzini
2013-11-06 17:48 ` Michael S. Tsirkin
2013-11-06 17:50 ` Paolo Bonzini
2013-11-06 18:39 ` Michael S. Tsirkin
2013-11-06 21:13 ` Paolo Bonzini [this message]
2013-11-06 21:36 ` Michael S. Tsirkin
2013-11-06 18:36 ` Luiz Capitulino
2013-11-06 21:11 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527AB0EC.8080200@redhat.com \
--to=pbonzini@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).