From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48810)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VeAPr-0002pc-3g
	for qemu-devel@nongnu.org; Wed, 06 Nov 2013 16:13:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VeAPh-0007Gl-Lr
	for qemu-devel@nongnu.org; Wed, 06 Nov 2013 16:13:31 -0500
Received: from mail-ea0-x231.google.com ([2a00:1450:4013:c01::231]:41134)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VeAPh-0007Gb-Em
	for qemu-devel@nongnu.org; Wed, 06 Nov 2013 16:13:21 -0500
Received: by mail-ea0-f177.google.com with SMTP id f15so38065eak.8
	for <qemu-devel@nongnu.org>; Wed, 06 Nov 2013 13:13:20 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <527AB0EC.8080200@redhat.com>
Date: Wed, 06 Nov 2013 22:13:16 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20131106112214.14a448b6@redhat.com> <527A7EDE.3060409@redhat.com>
	<20131106174834.GA11767@redhat.com> <527A814D.5020804@redhat.com>
	<20131106183912.GA16747@redhat.com>
In-Reply-To: <20131106183912.GA16747@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] BUG: QEMU aborts when setting breakpoint in gdb
	(bisected)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, marcel.a@redhat.com

Il 06/11/2013 19:39, Michael S. Tsirkin ha scritto:
> Because this will affect performance in unpredicatable way.

It's not really unpredictable.  It can be easily unit-tested, and anyway
the targets with 64-bit address spaces don't have any particular
performance problem.

> We can't make such changes in 1.7 IMHO:
> it would need much more than just a quick "works for me".

I can say the same about phys_page_find.  It's been obviously broken for
years and nobody ever cared, it cannot be super-urgent now to fix it.

Paolo

>> >  I don't feel confident
>> > changing phys_page_find, even if it's just 2 lines.
>> > 
>> > Paolo
> Well it's *obviously* broken if address is outside target address
> space.
> Take a look at the patch first, then argue.