From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeCFh-0004qn-Ak for qemu-devel@nongnu.org; Wed, 06 Nov 2013 18:11:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VeCFc-0006qw-A5 for qemu-devel@nongnu.org; Wed, 06 Nov 2013 18:11:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:24932) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeCFc-0006qs-0a for qemu-devel@nongnu.org; Wed, 06 Nov 2013 18:11:04 -0500 Message-ID: <527ACC85.9000203@redhat.com> Date: Wed, 06 Nov 2013 16:11:01 -0700 From: Eric Blake MIME-Version: 1.0 References: <1383743088-8139-1-git-send-email-quintela@redhat.com> <1383743088-8139-7-git-send-email-quintela@redhat.com> In-Reply-To: <1383743088-8139-7-git-send-email-quintela@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SFV63S2CCE1umfVv98ikXtm7TNJxjxDug" Subject: Re: [Qemu-devel] [PATCH 06/39] exec: create function to get a single dirty bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org Cc: chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SFV63S2CCE1umfVv98ikXtm7TNJxjxDug Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/06/2013 06:04 AM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > exec.c | 3 ++- > include/exec/memory-internal.h | 6 ++++++ > 2 files changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/exec.c b/exec.c > index 7cf5634..36b0a66 100644 > --- a/exec.c > +++ b/exec.c > @@ -1374,9 +1374,10 @@ found: > static void notdirty_mem_write(void *opaque, hwaddr ram_addr, > uint64_t val, unsigned size) > { > + > int dirty_flags; Is this whitespace addition spurious? =2E.. >=20 > +static inline bool cpu_physical_memory_get_dirty_flag(ram_addr_t addr,= > + int dirty_flag) Indentation off by one. But whitespace doesn't impact the patch, so you can mark 1 through 6 as: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --SFV63S2CCE1umfVv98ikXtm7TNJxjxDug Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSesyFAAoJEKeha0olJ0NqDAcH/iP5TTg028XTtnaArKZrg92+ cxvzs8NEg4+XHgM541s5JsdiRDyPjbUUsAlzNS9S7lnzs+O9wCav2RDnTMe+PEay K8vqsaYp5rXgph9wF/p+b466QIgCjg5tJ50gR5DrK/HcDemwfKNED8X/3IGkwLcw 9E2NG8mZXxzvnPzeTUFoYruZP1FiJQ2zvbF9iX8fFg/fbbuf+XzVb02GQWk21NA4 OZi+sbd8vmlOiV4pBKhq2KDis23w1ssSjXdUNaavDNC+PxA5ZzSRmXi1IU8gzJPP Fzd5vJw9JX8MpgV4JuTic8AYbuEMkTouQUeCiuLY9B2tlS+s03+L6FAHhGRwVZQ= =QsOV -----END PGP SIGNATURE----- --SFV63S2CCE1umfVv98ikXtm7TNJxjxDug--