From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeCHF-0006kT-Lk for qemu-devel@nongnu.org; Wed, 06 Nov 2013 18:12:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VeCHA-0007FN-PF for qemu-devel@nongnu.org; Wed, 06 Nov 2013 18:12:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:7768) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeCHA-0007FH-FP for qemu-devel@nongnu.org; Wed, 06 Nov 2013 18:12:40 -0500 Message-ID: <527ACCE5.308@redhat.com> Date: Wed, 06 Nov 2013 16:12:37 -0700 From: Eric Blake MIME-Version: 1.0 References: <1383743088-8139-1-git-send-email-quintela@redhat.com> <1383743088-8139-9-git-send-email-quintela@redhat.com> In-Reply-To: <1383743088-8139-9-git-send-email-quintela@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bkP1PqpV9gm6awMShVOPuEwS2tAn3kksl" Subject: Re: [Qemu-devel] [PATCH 08/39] exec: simplify notdirty_mem_write() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org Cc: chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --bkP1PqpV9gm6awMShVOPuEwS2tAn3kksl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/06/2013 06:04 AM, Juan Quintela wrote: > We don't need to make special things for CODE, just set the other two b= its >=20 > Signed-off-by: Juan Quintela > --- > exec.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) >=20 > diff --git a/exec.c b/exec.c > index 36b0a66..27e4540 100644 > --- a/exec.c > +++ b/exec.c > @@ -1374,12 +1374,8 @@ found: > static void notdirty_mem_write(void *opaque, hwaddr ram_addr, > uint64_t val, unsigned size) > { > - > - int dirty_flags; Huh, you just undid the whitespace addition I called out in 6/39. For 7 and 8, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --bkP1PqpV9gm6awMShVOPuEwS2tAn3kksl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSeszlAAoJEKeha0olJ0Nq7FQH/1G/1nvo0HFQ/qRfZ/E69IP/ omtntKpLF77lmiAOfkNq6AOR6IaK5rnLVzRLmPcJ/15qTnxvDOw65e55xpv1v6UW L9pHQjmQZt0eSAaPR13v0hMATK9WeoxmcfrON2Ha/zEPVVwF05grfCJQiyW9LmYx ZHHIOlrgey6rmri6CIgP5oGvTcg+Ktnpi/CRI2K8TuLeCwAh7wJ2hML44kzNpYtc tY2NFKaNBSYi9FBCyPdPNbduYdVrThmETQJweiqvWft66LgOQmobfRdbhUgYHTcf D4VrDHnUZ327NbAX8eaoheqJVmaeFpzhxDcymVOn37p9K9QW5BL3xndpSg9hfOc= =jb9O -----END PGP SIGNATURE----- --bkP1PqpV9gm6awMShVOPuEwS2tAn3kksl--